Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2201523002: DevTools: roll codemirror to @6d1379e29 (Closed)

Created:
4 years, 4 months ago by lushnikov
Modified:
4 years, 4 months ago
Reviewers:
einbinder
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: roll codemirror to @6d1379e29 The patch rolls CodeMirror to fix a wrong gutter background positioning. This fixes the SourceCode-Diff experiment rendering in case of horizontal source scroll. BUG=none R=einbinder Committed: https://crrev.com/9f9b08743bd1958cc6f04aa8b7e4f227927917f3 Cr-Commit-Position: refs/heads/master@{#408826}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M third_party/WebKit/Source/devtools/front_end/cm/codemirror.js View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
lushnikov
please, take a look
4 years, 4 months ago (2016-07-29 23:24:34 UTC) #1
einbinder
On 2016/07/29 23:24:34, lushnikov wrote: > please, take a look lgtm
4 years, 4 months ago (2016-07-29 23:28:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2201523002/1
4 years, 4 months ago (2016-07-29 23:30:44 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-30 00:59:48 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-30 01:01:28 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f9b08743bd1958cc6f04aa8b7e4f227927917f3
Cr-Commit-Position: refs/heads/master@{#408826}

Powered by Google App Engine
This is Rietveld 408576698