Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1062)

Issue 2201503002: [sync] Transient_invalidation_error in chrome://invalidations on Android. (Closed)

Created:
4 years, 4 months ago by Patrick Noland
Modified:
4 years, 4 months ago
Reviewers:
pavely
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sync] Transient_invalidation_error in chrome://invalidations on Android. invalidation_service_android never updated its logger instance's state, since the state is always enabled. This meant the logger only ever reported the state as its initial value, which is transient_error. This change causes invalidation_service_android to update the state to enabled upon construction. R=pavely@chromium.org BUG=630406 [sync] re-enable SyncTest#testRename Committed: https://crrev.com/0cd818d507de24f20c5a23f69cc94b52d7ace708 Cr-Commit-Position: refs/heads/master@{#408799}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/invalidation/impl/invalidation_service_android.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Patrick Noland
4 years, 4 months ago (2016-07-29 22:47:11 UTC) #3
pavely
lgtm
4 years, 4 months ago (2016-07-29 22:51:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2201503002/1
4 years, 4 months ago (2016-07-29 23:09:58 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 23:13:34 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 23:15:38 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0cd818d507de24f20c5a23f69cc94b52d7ace708
Cr-Commit-Position: refs/heads/master@{#408799}

Powered by Google App Engine
This is Rietveld 408576698