Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 2201493002: [Merge to M53] arc: Implement safe access to ArcAuthService. (Closed)

Created:
4 years, 4 months ago by Luis Héctor Chávez
Modified:
4 years, 4 months ago
Reviewers:
afakhry, xiyuan
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, extensions-reviews_chromium.org, yusukes+watch_chromium.org, tapted, tfarina, hidehiko+watch_chromium.org, dzhioev+watch_chromium.org, achuith+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org, Matt Giuca
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[Merge to M53] arc: Implement safe access to ArcAuthService. TEST=Extended browser_tests TEST=Manually on device with Arc enabled/disabled. BUG=627137 Review-Url: https://codereview.chromium.org/2149853004 Cr-Commit-Position: refs/heads/master@{#406307} (cherry picked from commit 4b937b462197e87d4ac0c44c0275b7a5350963c0) R=afakhry@chromium.org, xiyuan@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/b2ae94d69130233a271a36971b7a27f0f6ae8d08

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -30 lines) Patch
M chrome/browser/chromeos/arc/arc_auth_service.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_auth_service.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_auth_service_unittest.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_support_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/arc/arc_support_host.cc View 7 chunks +20 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/users/fake_chrome_user_manager.h View 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/feedback_private/feedback_private_api.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_views_browsertest.cc View 6 chunks +45 lines, -7 lines 0 comments Download
M components/user_manager/user_manager_base.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Luis Héctor Chávez
This is a cherry-pick on M53. PTAL on-behalf-of khmel@.
4 years, 4 months ago (2016-07-29 22:23:12 UTC) #2
afakhry
On 2016/07/29 22:23:12, Luis Héctor Chávez wrote: > This is a cherry-pick on M53. PTAL ...
4 years, 4 months ago (2016-07-29 22:42:44 UTC) #3
xiyuan
lgtm
4 years, 4 months ago (2016-08-01 15:28:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2201493002/1
4 years, 4 months ago (2016-08-01 15:33:57 UTC) #7
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 4 months ago (2016-08-01 15:33:59 UTC) #9
Luis Héctor Chávez
4 years, 4 months ago (2016-08-01 15:42:17 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b2ae94d69130233a271a36971b7a27f0f6ae8d08 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698