chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java - Issue 2201483002: Improve transition between opaque and translucent compositor views.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java

Issue 2201483002: Improve transition between opaque and translucent compositor views. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: now without VR-breaking badness Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java ('k') | chrome/android/java_sources.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java

index 949910611415b760cf75310cdf2484cea69d05f1..61e195c26370646217e5baf004fd8496923df8ee 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java

@@ -20,7 +20,6 @@ import android.util.AttributeSet;

import android.util.Pair;

import android.view.DragEvent;

import android.view.MotionEvent;

-import android.view.SurfaceView;

import android.view.View;

import android.view.ViewGroup;

import android.view.accessibility.AccessibilityEvent;

@@ -418,9 +417,9 @@ public class CompositorViewHolder extends FrameLayout

}

/**

- * @return The SurfaceView used by the Compositor.

+ * @return The SurfaceView proxy used by the Compositor.

- public SurfaceView getSurfaceView() {

+ public View getCompositorView() {

return mCompositorView;

}

@@ -976,7 +975,7 @@ public class CompositorViewHolder extends FrameLayout

mTabModelSelector = null;

mLayerTitleCache.setTabModelSelector(null);

setTab(null);

- getSurfaceView().setVisibility(View.INVISIBLE);

+ getCompositorView().setVisibility(View.INVISIBLE);

return selector;

}

@@ -986,7 +985,7 @@ public class CompositorViewHolder extends FrameLayout

* @param tabModelSelector

public void onExitVR(TabModelSelector tabModelSelector) {

- getSurfaceView().setVisibility(View.VISIBLE);

+ getCompositorView().setVisibility(View.VISIBLE);

attachToTabModelSelector(tabModelSelector);

}