chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java - Issue 2201483002: Improve transition between opaque and translucent compositor views.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 2201483002: Improve transition between opaque and translucent compositor views. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: unit tests Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorSurfaceManager.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

index c3d44906522197779a5eea376b5b8b7f6c03e4a2..415545bf9958e9afce67089c5d4d013f947e57ed 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

@@ -323,7 +323,7 @@ public abstract class ChromeActivity extends AsyncInitializationActivity

// Set up the animation placeholder to be the SurfaceView. This disables the

// SurfaceView's 'hole' clipping during animations that are notified to the window.

- mWindowAndroid.setAnimationPlaceholderView(mCompositorViewHolder.getSurfaceView());

+ mWindowAndroid.setAnimationPlaceholderView(mCompositorViewHolder.getCompositorView());

// Inform the WindowAndroid of the keyboard accessory view.

mWindowAndroid.setKeyboardAccessoryView((ViewGroup) findViewById(R.id.keyboard_accessory));