chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java - Issue 2201483002: Improve transition between opaque and translucent compositor views.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 2201483002: Improve transition between opaque and translucent compositor views. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: replaced hide logic with one counter Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorSurfaceManager.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorSurfaceManager.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

index 0b1db2bdc2a9b9109d58cd92e81a6cfbad45cde1..4fb969f543c2abeffe5486d9221ef9654579c1dd 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

@@ -1707,7 +1707,7 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode

// TODO(mthiesse): Toggle toolbar overlay, popups, etc.

public void setUIVisibilityForVR(int visibility) {

mControlContainer.setVisibility(visibility);

- getCompositorViewHolder().getSurfaceView().setVisibility(visibility);

+ getCompositorViewHolder().getCompositorView().setVisibility(visibility);

getCompositorViewHolder().setVisibility(visibility);

}