content/browser/renderer_host/compositor_impl_android.cc - Issue 2201483002: Improve transition between opaque and translucent compositor views.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/compositor_impl_android.cc

Issue 2201483002: Improve transition between opaque and translucent compositor views. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed CompositorSurfaceView Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/compositor_impl_android.cc

diff --git a/content/browser/renderer_host/compositor_impl_android.cc b/content/browser/renderer_host/compositor_impl_android.cc

index 718dd4e8f3645317926b702595cb1abd81aaa9ce..ad7b09bb0486cdb7c75c6667c7dcd6e50c330539 100644

--- a/content/browser/renderer_host/compositor_impl_android.cc

+++ b/content/browser/renderer_host/compositor_impl_android.cc

@@ -131,6 +131,12 @@ gpu::gles2::ContextCreationAttribHelper GetCompositorContextAttributes(

// specified

// (IOW check that a <= 0 && rgb > 0 && rgb <= 565) then alpha should be

// -1.

+ // TODO(liberato): This condition is memorized in ComositorView.java, to

+ // avoid using two surfaces temporarily during alpha <-> no alpha

+ // transitions. If these mismatch, then we risk a power regression if the

+ // SurfaceView is not marked as eOpaque (FORMAT_OPAQUE), and we have an

+ // EGL surface with an alpha channel. SurfaceFlinger needs at least one of

+ // those hints to optimize out alpha blending.

attributes.alpha_size = 0;

attributes.red_size = 5;

attributes.green_size = 6;