Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2201473002: Trun on canonical objects verification after reload (still have one workaround for immutable arrays… (Closed)

Created:
4 years, 4 months ago by siva
Modified:
4 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Trun on canonical objects verification after reload (still have one workaround for immutable arrays, which is related to the enum issue). R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/714cd8ee6bfcb37c30df1a162b3f944dcb96971c

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address code review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M runtime/vm/isolate.cc View 1 1 chunk +13 lines, -7 lines 0 comments Download
M runtime/vm/object.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
siva
4 years, 4 months ago (2016-07-29 22:08:43 UTC) #2
Cutch
lgtm https://codereview.chromium.org/2201473002/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/2201473002/diff/1/runtime/vm/object.cc#newcode15313 runtime/vm/object.cc:15313: // Temporary workaround for issue (26988). TODO(johnmccutchan):
4 years, 4 months ago (2016-08-01 14:58:50 UTC) #3
siva
https://codereview.chromium.org/2201473002/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/2201473002/diff/1/runtime/vm/object.cc#newcode15313 runtime/vm/object.cc:15313: // Temporary workaround for issue (26988). On 2016/08/01 14:58:50, ...
4 years, 4 months ago (2016-08-02 00:03:57 UTC) #4
siva
4 years, 4 months ago (2016-08-02 00:07:49 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
714cd8ee6bfcb37c30df1a162b3f944dcb96971c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698