blimp/client/core/feature/tab_control_feature.h - Issue 2201433002: Migrate TabControlFeature from 0.5 to 0.6

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/feature/tab_control_feature.h

Issue 2201433002: Migrate TabControlFeature from 0.5 to 0.6 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: git add blimp/client/public/contents/blimp_contents_observer.cc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/core/feature/tab_control_feature.h

diff --git a/blimp/client/feature/tab_control_feature.h b/blimp/client/core/feature/tab_control_feature.h

similarity index 89%

rename from blimp/client/feature/tab_control_feature.h

rename to blimp/client/core/feature/tab_control_feature.h

index 962d0c2d57b8526fcaa912e5bce0f3028a588451..fffaae7f7353450ab3dd8e2b73571dd774cccd93 100644

--- a/blimp/client/feature/tab_control_feature.h

+++ b/blimp/client/core/feature/tab_control_feature.h

@@ -2,8 +2,8 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#ifndef BLIMP_CLIENT_FEATURE_TAB_CONTROL_FEATURE_H_

-#define BLIMP_CLIENT_FEATURE_TAB_CONTROL_FEATURE_H_

+#ifndef BLIMP_CLIENT_CORE_FEATURE_TAB_CONTROL_FEATURE_H_

nyquist 2016/08/05 23:03:23 Could you instead move this to //blimp/client/core

Menglin 2016/08/06 00:57:00 Done

+#define BLIMP_CLIENT_CORE_FEATURE_TAB_CONTROL_FEATURE_H_

#include <memory>

@@ -53,4 +53,4 @@ class TabControlFeature : public BlimpMessageProcessor {

} // namespace client

} // namespace blimp

-#endif // BLIMP_CLIENT_FEATURE_TAB_CONTROL_FEATURE_H_

+#endif // BLIMP_CLIENT_CORE_FEATURE_TAB_CONTROL_FEATURE_H_