Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1432)

Unified Diff: blimp/client/core/contents/blimp_contents_impl_unittest.cc

Issue 2201433002: Migrate TabControlFeature from 0.5 to 0.6 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: some more compile error fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/contents/blimp_contents_impl_unittest.cc
diff --git a/blimp/client/core/contents/blimp_contents_impl_unittest.cc b/blimp/client/core/contents/blimp_contents_impl_unittest.cc
index 555cbbe913ac298c31c00076895fe6a27a81a2c3..98fa2066246edf05c0c085cd0116196bd5a7edec 100644
--- a/blimp/client/core/contents/blimp_contents_impl_unittest.cc
+++ b/blimp/client/core/contents/blimp_contents_impl_unittest.cc
@@ -17,10 +17,12 @@ namespace {
const char kExampleURL[] = "https://www.example.com/";
const char kOtherExampleURL[] = "https://www.otherexample.com/";
+const int kDummyTabId = 0;
class MockBlimpContentsObserver : public BlimpContentsObserver {
public:
- MockBlimpContentsObserver() = default;
+ explicit MockBlimpContentsObserver(BlimpContents* blimp_contents)
+ : BlimpContentsObserver(blimp_contents) {}
~MockBlimpContentsObserver() override = default;
MOCK_METHOD0(OnNavigationStateChanged, void());
@@ -31,7 +33,7 @@ class MockBlimpContentsObserver : public BlimpContentsObserver {
TEST(BlimpContentsImplTest, LoadURLAndNotifyObservers) {
base::MessageLoop loop;
- BlimpContentsImpl blimp_contents;
+ BlimpContentsImpl blimp_contents(kDummyTabId);
BlimpNavigationControllerImpl& navigation_controller =
blimp_contents.GetNavigationController();
@@ -39,10 +41,8 @@ TEST(BlimpContentsImplTest, LoadURLAndNotifyObservers) {
feature.SetDelegate(1, &navigation_controller);
navigation_controller.SetNavigationFeatureForTesting(&feature);
- testing::StrictMock<MockBlimpContentsObserver> observer1;
- blimp_contents.AddObserver(&observer1);
- testing::StrictMock<MockBlimpContentsObserver> observer2;
- blimp_contents.AddObserver(&observer2);
+ testing::StrictMock<MockBlimpContentsObserver> observer1(&blimp_contents);
+ testing::StrictMock<MockBlimpContentsObserver> observer2(&blimp_contents);
EXPECT_CALL(observer1, OnNavigationStateChanged());
EXPECT_CALL(observer2, OnNavigationStateChanged()).Times(2);
« no previous file with comments | « blimp/client/core/contents/blimp_contents_impl.cc ('k') | blimp/client/core/contents/blimp_contents_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698