blimp/client/core/contents/android/blimp_contents_observer_proxy.cc - Issue 2201433002: Migrate TabControlFeature from 0.5 to 0.6

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/contents/android/blimp_contents_observer_proxy.cc

Issue 2201433002: Migrate TabControlFeature from 0.5 to 0.6 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: some more compile error fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « blimp/client/core/contents/android/blimp_contents_factory.cc ('k') | blimp/client/core/contents/blimp_contents_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/core/contents/android/blimp_contents_observer_proxy.cc

diff --git a/blimp/client/core/contents/android/blimp_contents_observer_proxy.cc b/blimp/client/core/contents/android/blimp_contents_observer_proxy.cc

index 61d668fce9984f9769e0f75eee803d86fd330ee3..e53c09fb7eedc39500d576347296653c8305735e 100644

--- a/blimp/client/core/contents/android/blimp_contents_observer_proxy.cc

+++ b/blimp/client/core/contents/android/blimp_contents_observer_proxy.cc

@@ -33,9 +33,9 @@ BlimpContentsObserverProxy::BlimpContentsObserverProxy(

JNIEnv* env,

jobject obj,

BlimpContentsImplAndroid* blimp_contents_impl_android)

- : blimp_contents_impl_android_(blimp_contents_impl_android) {

+ : BlimpContentsObserver(blimp_contents_impl_android->blimp_contents_impl()),

+ blimp_contents_impl_android_(blimp_contents_impl_android) {

java_obj_.Reset(env, obj);

- blimp_contents_impl_android_->blimp_contents_impl()->AddObserver(this);

}

BlimpContentsObserverProxy::~BlimpContentsObserverProxy() {}

« no previous file with comments | « blimp/client/core/contents/android/blimp_contents_factory.cc ('k') | blimp/client/core/contents/blimp_contents_impl.h » ('j') | no next file with comments »