Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3998)

Unified Diff: blimp/client/core/contents/blimp_contents_impl.cc

Issue 2201433002: Migrate TabControlFeature from 0.5 to 0.6 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/contents/blimp_contents_impl.cc
diff --git a/blimp/client/core/contents/blimp_contents_impl.cc b/blimp/client/core/contents/blimp_contents_impl.cc
index 37d25a9ad5d172435c2ef24eba5a15cf65596921..f107e076b1f25d04732642f7b0d2809a131f4e9f 100644
--- a/blimp/client/core/contents/blimp_contents_impl.cc
+++ b/blimp/client/core/contents/blimp_contents_impl.cc
@@ -24,7 +24,12 @@ const char kBlimpContentsImplAndroidKey[] = "blimp_contents_impl_android";
BlimpContentsImpl::BlimpContentsImpl() : navigation_controller_(this) {}
David Trainor- moved to gerrit 2016/08/03 18:55:42 What do we initialize id_ to in the default constr
Menglin 2016/08/03 23:49:59 Yeah we can remove the default constructor.
-BlimpContentsImpl::~BlimpContentsImpl() {}
+BlimpContentsImpl::BlimpContentsImpl(int id)
+ : navigation_controller_(this), id_(id) {}
+
+BlimpContentsImpl::~BlimpContentsImpl() {
+ FOR_EACH_OBSERVER(BlimpContentsObserver, observers_, OnContentsDestroyed());
+}
#if defined(OS_ANDROID)

Powered by Google App Engine
This is Rietveld 408576698