Migrate TabControlFeature from 0.5 to 0.6

blimp/client/public/contents/blimp_contents_observer.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BLIMP_CLIENT_PUBLIC_CONTENTS_BLIMP_CONTENTS_OBSERVER_H_
 #define BLIMP_CLIENT_PUBLIC_CONTENTS_BLIMP_CONTENTS_OBSERVER_H_
 
 #include "base/macros.h"
 #include "url/gurl.h"
 
 namespace blimp {
 namespace client {
 
+class BlimpContents;
+
 // An observer API implemented by classes which are interested in various events
 // related to BlimpContents.
 class BlimpContentsObserver {
  public:
-  virtual ~BlimpContentsObserver() = default;
+  virtual ~BlimpContentsObserver();
 
   // Invoked when the navigation state of the BlimpContents has changed.
   virtual void OnNavigationStateChanged() {}
 
+  // Invoke when the destructor of blimp contents is called. This will clear
+  // the contents_ to nullptr.
+  virtual void BlimpContentsDying();

[David Trainor- moved to gerrit, 2016/08/09 05:34:12]

Don't make this virtual and put it at the end of the public methods (not in the
middle of the virtual methods).

[Menglin, 2016/08/09 18:19:31]

Right. I think i somehow added virtual when i was debugging some error and
forgot to delete it. Thanks for the good catch!

+
+  // Called by BlimpContentsDying().
+  virtual void OnContentsDestroyed() {}
+
+  BlimpContents* blimp_contents() { return contents_; }
+
  protected:
-  BlimpContentsObserver() {}
+  explicit BlimpContentsObserver(BlimpContents* blimp_contents);
 
  private:
+  // The BlimpContents being tracked by this BlimpContentsObserver.
+  BlimpContents* contents_;
+
   DISALLOW_COPY_AND_ASSIGN(BlimpContentsObserver);
 };
 
 }  // namespace client
 }  // namespace blimp
 
 #endif  // BLIMP_CLIENT_PUBLIC_CONTENTS_BLIMP_CONTENTS_OBSERVER_H_