Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2201323004: mash: Use wm::WmSnapToPixelLayoutManager for the shelf. (Closed)

Created:
4 years, 4 months ago by msw
Modified:
4 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Use wm::WmSnapToPixelLayoutManager for the shelf. Convert ShelfLayoutManager and StatusAreaLayoutManager. BUG=615155 TEST=Automated; no layout behavior changes. R=sky@chromium.org Committed: https://crrev.com/bb3e9628d4c1e5e281d85970a4df410c5b0a14d1 Cr-Commit-Position: refs/heads/master@{#409902}

Patch Set 1 #

Patch Set 2 : Also convert the StatusAreaLayoutManager. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -36 lines) Patch
M ash/shelf/shelf_layout_manager.h View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 1 2 chunks +7 lines, -7 lines 0 comments Download
M ash/shelf/shelf_widget.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M ash/wm/status_area_layout_manager.h View 1 2 chunks +7 lines, -8 lines 0 comments Download
M ash/wm/status_area_layout_manager.cc View 1 4 chunks +13 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
msw
Hey Scott, please take a look; thanks!
4 years, 4 months ago (2016-08-04 19:48:28 UTC) #3
sky
LGTM
4 years, 4 months ago (2016-08-04 20:53:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2201323004/20001
4 years, 4 months ago (2016-08-04 21:14:29 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-04 21:18:23 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 21:19:48 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bb3e9628d4c1e5e281d85970a4df410c5b0a14d1
Cr-Commit-Position: refs/heads/master@{#409902}

Powered by Google App Engine
This is Rietveld 408576698