Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Side by Side Diff: ash/common/system/chromeos/virtual_keyboard/virtual_keyboard_tray.h

Issue 2201323002: Simplify VirtualKeyboardTray (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ASH_COMMON_SYSTEM_CHROMEOS_VIRTUAL_KEYBOARD_VIRTUAL_KEYBOARD_TRAY_H_ 5 #ifndef ASH_COMMON_SYSTEM_CHROMEOS_VIRTUAL_KEYBOARD_VIRTUAL_KEYBOARD_TRAY_H_
6 #define ASH_COMMON_SYSTEM_CHROMEOS_VIRTUAL_KEYBOARD_VIRTUAL_KEYBOARD_TRAY_H_ 6 #define ASH_COMMON_SYSTEM_CHROMEOS_VIRTUAL_KEYBOARD_VIRTUAL_KEYBOARD_TRAY_H_
7 7
8 #include "ash/common/keyboard/keyboard_ui_observer.h" 8 #include "ash/common/keyboard/keyboard_ui_observer.h"
9 #include "ash/common/system/tray/tray_background_view.h" 9 #include "ash/common/system/tray/tray_background_view.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "ui/views/controls/button/button.h" 11 #include "ui/keyboard/keyboard_controller_observer.h"
12 12
13 namespace views { 13 namespace views {
14 class ImageButton; 14 class ImageView;
15 } 15 }
16 16
17 namespace ash { 17 namespace ash {
18 18
19 // TODO(sky): make this visible on non-chromeos platforms. 19 // TODO(sky): make this visible on non-chromeos platforms.
20 class VirtualKeyboardTray : public TrayBackgroundView, 20 class VirtualKeyboardTray : public TrayBackgroundView,
21 public views::ButtonListener, 21 public KeyboardUIObserver,
22 public KeyboardUIObserver { 22 public keyboard::KeyboardControllerObserver {
23 public: 23 public:
24 explicit VirtualKeyboardTray(WmShelf* wm_shelf); 24 explicit VirtualKeyboardTray(WmShelf* wm_shelf);
25 ~VirtualKeyboardTray() override; 25 ~VirtualKeyboardTray() override;
26 26
27 // TrayBackgroundView: 27 // TrayBackgroundView:
28 void SetShelfAlignment(ShelfAlignment alignment) override; 28 void SetShelfAlignment(ShelfAlignment alignment) override;
29 base::string16 GetAccessibleNameForTray() override; 29 base::string16 GetAccessibleNameForTray() override;
30 void HideBubbleWithView(const views::TrayBubbleView* bubble_view) override; 30 void HideBubbleWithView(const views::TrayBubbleView* bubble_view) override;
31 void ClickedOutsideBubble() override; 31 void ClickedOutsideBubble() override;
32 bool PerformAction(const ui::Event& event) override; 32 bool PerformAction(const ui::Event& event) override;
33 33
34 // views::ButtonListener:
35 void ButtonPressed(views::Button* sender, const ui::Event& event) override;
36
37 // KeyboardUIObserver: 34 // KeyboardUIObserver:
38 void OnKeyboardEnabledStateChanged(bool new_value) override; 35 void OnKeyboardEnabledStateChanged(bool new_value) override;
39 36
37 // keyboard::KeyboardControllerObserver:
38 void OnKeyboardBoundsChanging(const gfx::Rect& new_bounds) override;
39
40 private: 40 private:
41 views::ImageButton* button_; // Not owned. 41 // Creates a new border for the icon. The padding is determined based on the
42 // alignment of the shelf.
43 void SetIconBorderForShelfAlignment();
44
45 void ObserveKeyboardController();
46 void UnobserveKeyboardController();
47
48 // Weak pointer, will be parented by TrayContainer for its lifetime.
49 views::ImageView* icon_;
42 50
43 DISALLOW_COPY_AND_ASSIGN(VirtualKeyboardTray); 51 DISALLOW_COPY_AND_ASSIGN(VirtualKeyboardTray);
44 }; 52 };
45 53
46 } // namespace ash 54 } // namespace ash
47 55
48 #endif // ASH_COMMON_SYSTEM_CHROMEOS_VIRTUAL_KEYBOARD_VIRTUAL_KEYBOARD_TRAY_H_ 56 #endif // ASH_COMMON_SYSTEM_CHROMEOS_VIRTUAL_KEYBOARD_VIRTUAL_KEYBOARD_TRAY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698