Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2201313002: Revert of Load data URI images in an async way according to spec (Closed)

Created:
4 years, 4 months ago by Yoav Weiss
Modified:
4 years, 4 months ago
CC:
chromium-reviews, tyoshino+watch_chromium.org, blink-reviews-html_chromium.org, loading-reviews_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, blink-reviews, kinuko+watch, Nate Chapin, kouhei (in TOK), mdjones, nyquist
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Load data URI images in an async way according to spec (patchset #5 id:80001 of https://codereview.chromium.org/2173003002/ ) Reason for revert: Reverting due to https://bugs.chromium.org/p/chromium/issues/detail?id=632277 Seems like the dev tools' screen capture functionality relies on the sync bahavior of data URIs (issue reproduces with the patch, and does not when reverted) R=pdr, csharrison Original issue's description: > Load data URI images in an async way according to spec > > According to https://github.com/ResponsiveImagesCG/picture-element/issues/223#issuecomment-69772765 > we seem to be the only browser that loads data URIs immediately (as if they were cached). > It was introduced as part of the move to async image loading: https://codereview.chromium.org/200923002 > > This is now causing issues: https://code.google.com/p/chromium/issues/detail?id=469131 > > This CL changes this behavior to be spec compliant and load data URIs asynchronously, like other resources. > > This is relanding https://codereview.chromium.org/1492303003 > > BUG=514206 > > Committed: https://crrev.com/d0c9ac3bf5bb4843c2c189a72e7b6c39e6743831 > Cr-Commit-Position: refs/heads/master@{#407616} TBR=pdr@chromium.org,csharrison@chromium.org,nyquist@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=514206 Committed: https://crrev.com/11a418f2c62a7902e0ca4445aa4769a25416e4e0 Cr-Commit-Position: refs/heads/master@{#410391}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -100 lines) Patch
M third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-out-of-bounds-src.html View 2 chunks +10 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/HTMLImageElement/image-async-loading-data-uris.html View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/basic-buttons.html View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-blocked-data-uri-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/loader/data-uri-images-load-asynchronously.html View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/loader/data-uri-images-load-asynchronously-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/loader/data-uri-images-load-synchronously.html View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/loader/data-uri-images-load-synchronously-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/loader/data-uri-images-reload-asynchronously.html View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/loader/data-uri-images-reload-asynchronously-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/loader/data-uri-images-reload-synchronously.html View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/loader/data-uri-images-reload-synchronously-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/canvas/canvas-draw-image-globalalpha.html View 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/canvas/image-svg-intrinsic-size.html View 1 chunk +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLSrcsetParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/ImageLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Yoav Weiss
Created Revert of Load data URI images in an async way according to spec
4 years, 4 months ago (2016-08-03 04:11:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2201313002/1
4 years, 4 months ago (2016-08-03 04:11:38 UTC) #3
Charlie Harrison
lgtm :( was really hoping this time it would go through!
4 years, 4 months ago (2016-08-03 04:13:29 UTC) #4
pdr.
noooooo LGTM :(
4 years, 4 months ago (2016-08-03 04:13:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/203063)
4 years, 4 months ago (2016-08-03 05:33:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2201313002/1
4 years, 4 months ago (2016-08-08 16:48:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 18:03:42 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 18:05:27 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11a418f2c62a7902e0ca4445aa4769a25416e4e0
Cr-Commit-Position: refs/heads/master@{#410391}

Powered by Google App Engine
This is Rietveld 408576698