Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 2201293002: FIELDSET element should not check inner controls in checkValidity(). (Closed)

Created:
4 years, 4 months ago by tkent
Modified:
4 years, 4 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

FIELDSET element should not check inner controls in checkValidity(). fieldset.checkValidity() referred to inner control validity state by accident. The common implmentatin of checkValidity() just calls isValidElement(), and FIELDSET's isValidElement() checks inner controls validity for :valid/:invalid. This CL adds willValidate check to the common checkValidity(). Also, it exposed an issue described in HTMLFormControlElement::setNeedsWillValidateCheck() because we used to clear m_validityIsDirty in checkValidity(). BUG=633794 Committed: https://crrev.com/52ccdca1f50ae313029eb6e996a3ef4288b3f638 Cr-Commit-Position: refs/heads/master@{#409500}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/fast/forms/checkValidity-001.html View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/checkValidity-001-expected.txt View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
tkent
Keishi, would you review this please?
4 years, 4 months ago (2016-08-03 05:05:06 UTC) #5
keishi
LGTM
4 years, 4 months ago (2016-08-03 09:44:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2201293002/1
4 years, 4 months ago (2016-08-03 11:56:52 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 13:23:08 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 13:26:03 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/52ccdca1f50ae313029eb6e996a3ef4288b3f638
Cr-Commit-Position: refs/heads/master@{#409500}

Powered by Google App Engine
This is Rietveld 408576698