Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2201273002: Revert of [Sync] Merge sync_unit_tests into components_unit_tests, take 2. (Closed)

Created:
4 years, 4 months ago by kozy
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, slan, jam, maxbogue
CC:
chromium-reviews, lcwu+watch_chromium.org, mikecase+watch_chromium.org, halliwell+watch_chromium.org, alokp+watch_chromium.org, glider+watch_chromium.org, jbudorick+watch_chromium.org, sync-reviews_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Sync] Merge sync_unit_tests into components_unit_tests, take 2. (patchset #1 id:1 of https://codereview.chromium.org/2199113003/ ) Reason for revert: This breaks compile step on official.desktop.continuous for all OS trunk. crbug.com/633775 Original issue's description: > [Sync] Merge sync_unit_tests into components_unit_tests, take 2. > > This change was previously landed and reverted because some bot configs > in the build repo needed to be updated first. > > BUG=626114 > TBR=dpranke,jam,slan > > Committed: https://crrev.com/9f7c262325b965be2a51475650d542c9791eee9d > Cr-Commit-Position: refs/heads/master@{#409060} > > patch from issue 2186733002 at patchset 60001 (http://crrev.com/2186733002#ps60001) > > Committed: https://crrev.com/9131f18a585a66ad327af8089d3fb80c10388948 > Cr-Commit-Position: refs/heads/master@{#409356} TBR=dpranke@chromium.org,jam@chromium.org,slan@chromium.org,maxbogue@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=626114, 633775 Committed: https://crrev.com/523ee7dd9be18c54a45ca4ff499d57e1cac4495c Cr-Commit-Position: refs/heads/master@{#409386}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+738 lines, -95 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M build/all.gyp View 9 chunks +9 lines, -0 lines 0 comments Download
M build/android/pylib/gtest/gtest_config.py View 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/gtest/gtest_test_instance.py View 1 chunk +1 line, -0 lines 0 comments Download
M build/gn_migration.gypi View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 chunk +5 lines, -0 lines 0 comments Download
M chromecast/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M chromecast/chromecast_tests.gypi View 3 chunks +3 lines, -0 lines 0 comments Download
M components/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/components_tests.gyp View 5 chunks +2 lines, -92 lines 0 comments Download
M components/sync/BUILD.gn View 2 chunks +3 lines, -2 lines 0 comments Download
M components/sync/sync_tests.gypi View 2 chunks +184 lines, -0 lines 0 comments Download
A components/sync/sync_unit_tests_apk.isolate View 1 chunk +24 lines, -0 lines 0 comments Download
A components/sync_unit_tests.isolate View 1 chunk +32 lines, -0 lines 0 comments Download
M ios/build/bots/tests/common_tests.json View 1 chunk +3 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.android.json View 10 chunks +50 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 3 chunks +18 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.full.json View 3 chunks +18 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 39 chunks +223 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 6 chunks +41 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 5 chunks +25 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 3 chunks +18 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.full.json View 3 chunks +18 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 3 chunks +18 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 4 chunks +24 lines, -0 lines 0 comments Download
M testing/buildbot/chromium_memory_trybot.json View 1 chunk +1 line, -0 lines 0 comments Download
M testing/buildbot/client.v8.fyi.json View 1 chunk +1 line, -0 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +4 lines, -0 lines 0 comments Download
M testing/buildbot/tryserver.v8.json View 1 chunk +1 line, -0 lines 0 comments Download
M tools/valgrind/chrome_tests.py View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
kozy
Created Revert of [Sync] Merge sync_unit_tests into components_unit_tests, take 2.
4 years, 4 months ago (2016-08-02 23:59:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2201273002/1
4 years, 4 months ago (2016-08-02 23:59:54 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 00:01:11 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/523ee7dd9be18c54a45ca4ff499d57e1cac4495c Cr-Commit-Position: refs/heads/master@{#409386}
4 years, 4 months ago (2016-08-03 00:02:33 UTC) #8
Dirk Pranke
4 years, 4 months ago (2016-08-03 00:03:12 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698