chrome/browser/resources/settings/privacy_page/privacy_page.html - Issue 2201243002: [MD settings] layout of site details permissions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/privacy_page/privacy_page.html

Issue 2201243002: [MD settings] layout of site details permissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed label Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/privacy_page/privacy_page.html

diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.html b/chrome/browser/resources/settings/privacy_page/privacy_page.html

index 396235ff8a2575abacc79de2e03658719a4f691e..c07326fa3d95993d02d31617991cd6c995855b1a 100644

--- a/chrome/browser/resources/settings/privacy_page/privacy_page.html

+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.html

@@ -266,7 +266,7 @@

<settings-subpage

- page-title="$i18n{siteSettingsSiteDetailsPageTitle}">

+ page-title="[[selectedSite.originForDisplay]]">

tommycli 2016/08/04 01:41:02 Can we just axe the i18n string from settings_stri

dschuyler 2016/08/04 20:03:52 Good call, I'd meant to do that. Done.

<site-details site="[[selectedSite]]"></site-details>

</settings-subpage>

</template>