[MD settings] layout of site details permissions

[MD settings] layout of site details permissions

This CL changes the layout of the site settings details to better match
the mocks. The Clear and reset button is changed style; the url is in
the subpage title; and the indentation is corrected.

BUG=627998, 633043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a332231ff426890f175933a02e2fa3efdcdfff70
Cr-Commit-Position: refs/heads/master@{#409886}

[dschuyler, 2016-08-02 22:51:02]

Description was changed from

==========
[MD settings] layout of site details permissions

This CL changes the layout of the site settings details to better match
the mocks. The Clear and reset button is changed style; the url is in
the subpage title; and the indentation is corrected.

BUG=633043
==========

to

==========
[MD settings] layout of site details permissions

This CL changes the layout of the site settings details to better match
the mocks. The Clear and reset button is changed style; the url is in
the subpage title; and the indentation is corrected.

BUG=633043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-08-02 22:51:04]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 22:51:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-08-02 22:55:55]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 22:56:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-08-02 22:57:34]

Patchset #1 (id:1) has been deleted

[dschuyler, 2016-08-02 22:57:47]

dschuyler@chromium.org changed reviewers:
+ tommycli@chromium.org

[dschuyler, 2016-08-02 22:59:37]

Description was changed from

==========
[MD settings] layout of site details permissions

This CL changes the layout of the site settings details to better match
the mocks. The Clear and reset button is changed style; the url is in
the subpage title; and the indentation is corrected.

BUG=633043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] layout of site details permissions

This CL changes the layout of the site settings details to better match
the mocks. The Clear and reset button is changed style; the url is in
the subpage title; and the indentation is corrected.

BUG=627998, 633043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-08-02 23:54:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 23:54:59]

Dry run: This issue passed the CQ dry run.

[tommycli, 2016-08-04 01:41:02]

Hey Dave. Sorry for the delay. Here are some comments.

https://codereview.chromium.org/2201243002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/privacy_page/privacy_page.html (right):

https://codereview.chromium.org/2201243002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/privacy_page/privacy_page.html:269:
page-title="[[selectedSite.originForDisplay]]">
Can we just axe the i18n string from settings_strings and
md_localized_strings_provider now?

https://codereview.chromium.org/2201243002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_details.html (right):

https://codereview.chromium.org/2201243002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_details.html:19: <!--
TODO(dschuyler): change this to a dom-if. -->
Why not do it now? Or you could just leave it hidden, and that seems OK to me
too.

[dschuyler, 2016-08-04 18:49:52]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 18:51:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 20:03:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 20:03:10]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2016-08-04 20:03:52]

https://codereview.chromium.org/2201243002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/privacy_page/privacy_page.html (right):

https://codereview.chromium.org/2201243002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/privacy_page/privacy_page.html:269:
page-title="[[selectedSite.originForDisplay]]">
On 2016/08/04 01:41:02, tommycli wrote:
> Can we just axe the i18n string from settings_strings and
> md_localized_strings_provider now?

Good call, I'd meant to do that.
Done.

https://codereview.chromium.org/2201243002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_details.html (right):

https://codereview.chromium.org/2201243002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_details.html:19: <!--
TODO(dschuyler): change this to a dom-if. -->
On 2016/08/04 01:41:02, tommycli wrote:
> Why not do it now? Or you could just leave it hidden, and that seems OK to me
> too.

Done.

[tommycli, 2016-08-04 20:17:34]

lgtm thanks

[dschuyler, 2016-08-04 20:17:58]

The CQ bit was checked by dschuyler@chromium.org

[tommycli, 2016-08-04 20:18:01]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2016-08-04 20:18:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 20:22:14]

Description was changed from

==========
[MD settings] layout of site details permissions

This CL changes the layout of the site settings details to better match
the mocks. The Clear and reset button is changed style; the url is in
the subpage title; and the indentation is corrected.

BUG=627998, 633043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] layout of site details permissions

This CL changes the layout of the site settings details to better match
the mocks. The Clear and reset button is changed style; the url is in
the subpage title; and the indentation is corrected.

BUG=627998, 633043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-08-04 20:22:16]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-08-04 20:23:55]

Description was changed from

==========
[MD settings] layout of site details permissions

This CL changes the layout of the site settings details to better match
the mocks. The Clear and reset button is changed style; the url is in
the subpage title; and the indentation is corrected.

BUG=627998, 633043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] layout of site details permissions

This CL changes the layout of the site settings details to better match
the mocks. The Clear and reset button is changed style; the url is in
the subpage title; and the indentation is corrected.

BUG=627998, 633043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a332231ff426890f175933a02e2fa3efdcdfff70
Cr-Commit-Position: refs/heads/master@{#409886}
==========

[commit-bot: I haz the power, 2016-08-04 20:23:57]

Patchset 2 (id:??) landed as
https://crrev.com/a332231ff426890f175933a02e2fa3efdcdfff70
Cr-Commit-Position: refs/heads/master@{#409886}