Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2201233003:
GN: gpu support in tools (Closed)
DescriptionGN: gpu support in tools
If you want to try this out, the DOCS_PREVIEW link is a quickstart.
Are the GrGLCreateNativeInteface_* meant to be part of Skia-the-library
or just used by testing tools? I've got it written here as tool-only,
but we could easily move it to libskia if it's a thing we want to ship.
I'm honestly not sure I understand how this linked before without a definition
of GrGLCreateNativeInterface(). Or are there two, one real and one no-op
default with some sort of weak linking setup? dlopen()?
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201233003
DOCS_PREVIEW= https://skia.org/user/quick/gn?cl=2201233003
Committed: https://skia.googlesource.com/skia/+/5259da5377a27298939fcef677851d46c75badde
Patch Set 1 #Patch Set 2 : typo #Patch Set 3 : doc #Patch Set 4 : case-o #Messages
Total messages: 21 (16 generated)
Description was changed from ========== GN: gpu support in tools Are the GrGLCreateNativeInteface_* meant to be part of Skia-the-library or just used by testing tools? I've got it written here as tool-only, but we could easily move it to libskia if it's a thing we want to ship. I'm honestly not sure I understand how this linked before without a definition of GrGLCreateNativeInterface(). Or are there two, one real and one no-op default with some sort of weak linking setup? dlopen()? BUG=skia: ========== to ========== GN: gpu support in tools Are the GrGLCreateNativeInteface_* meant to be part of Skia-the-library or just used by testing tools? I've got it written here as tool-only, but we could easily move it to libskia if it's a thing we want to ship. I'm honestly not sure I understand how this linked before without a definition of GrGLCreateNativeInterface(). Or are there two, one real and one no-op default with some sort of weak linking setup? dlopen()? BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201233003 ==========
Description was changed from ========== GN: gpu support in tools Are the GrGLCreateNativeInteface_* meant to be part of Skia-the-library or just used by testing tools? I've got it written here as tool-only, but we could easily move it to libskia if it's a thing we want to ship. I'm honestly not sure I understand how this linked before without a definition of GrGLCreateNativeInterface(). Or are there two, one real and one no-op default with some sort of weak linking setup? dlopen()? BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201233003 ========== to ========== GN: gpu support in tools Are the GrGLCreateNativeInteface_* meant to be part of Skia-the-library or just used by testing tools? I've got it written here as tool-only, but we could easily move it to libskia if it's a thing we want to ship. I'm honestly not sure I understand how this linked before without a definition of GrGLCreateNativeInterface(). Or are there two, one real and one no-op default with some sort of weak linking setup? dlopen()? BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201233003 DOCS_PREVIEW= https://skia.org/?cl=2201233003 ==========
Description was changed from ========== GN: gpu support in tools Are the GrGLCreateNativeInteface_* meant to be part of Skia-the-library or just used by testing tools? I've got it written here as tool-only, but we could easily move it to libskia if it's a thing we want to ship. I'm honestly not sure I understand how this linked before without a definition of GrGLCreateNativeInterface(). Or are there two, one real and one no-op default with some sort of weak linking setup? dlopen()? BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201233003 DOCS_PREVIEW= https://skia.org/?cl=2201233003 ========== to ========== GN: gpu support in tools If you want to try this out, the DOCS_PREVIEW link is a quickstart. Are the GrGLCreateNativeInteface_* meant to be part of Skia-the-library or just used by testing tools? I've got it written here as tool-only, but we could easily move it to libskia if it's a thing we want to ship. I'm honestly not sure I understand how this linked before without a definition of GrGLCreateNativeInterface(). Or are there two, one real and one no-op default with some sort of weak linking setup? dlopen()? BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201233003 DOCS_PREVIEW=https://skia.org/user/quick/gn?cl=2201233003 ==========
Description was changed from ========== GN: gpu support in tools If you want to try this out, the DOCS_PREVIEW link is a quickstart. Are the GrGLCreateNativeInteface_* meant to be part of Skia-the-library or just used by testing tools? I've got it written here as tool-only, but we could easily move it to libskia if it's a thing we want to ship. I'm honestly not sure I understand how this linked before without a definition of GrGLCreateNativeInterface(). Or are there two, one real and one no-op default with some sort of weak linking setup? dlopen()? BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201233003 DOCS_PREVIEW=https://skia.org/user/quick/gn?cl=2201233003 ========== to ========== GN: gpu support in tools If you want to try this out, the DOCS_PREVIEW link is a quickstart. Are the GrGLCreateNativeInteface_* meant to be part of Skia-the-library or just used by testing tools? I've got it written here as tool-only, but we could easily move it to libskia if it's a thing we want to ship. I'm honestly not sure I understand how this linked before without a definition of GrGLCreateNativeInterface(). Or are there two, one real and one no-op default with some sort of weak linking setup? dlopen()? BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201233003 DOCS_PREVIEW= https://skia.org/user/quick/gn?cl=2201233003 ==========
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-GN-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...) Build-Ubuntu-GCC-x86_64-Release-GN-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
mtklein@chromium.org changed reviewers: + bsalomon@google.com
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
jcgregorio@google.com changed reviewers: + jcgregorio@google.com
lgtm
The CQ bit was checked by mtklein@chromium.org
Ah, Brian is on vacation. This will have to be an "ask for forgiveness" CL...
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== GN: gpu support in tools If you want to try this out, the DOCS_PREVIEW link is a quickstart. Are the GrGLCreateNativeInteface_* meant to be part of Skia-the-library or just used by testing tools? I've got it written here as tool-only, but we could easily move it to libskia if it's a thing we want to ship. I'm honestly not sure I understand how this linked before without a definition of GrGLCreateNativeInterface(). Or are there two, one real and one no-op default with some sort of weak linking setup? dlopen()? BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201233003 DOCS_PREVIEW= https://skia.org/user/quick/gn?cl=2201233003 ========== to ========== GN: gpu support in tools If you want to try this out, the DOCS_PREVIEW link is a quickstart. Are the GrGLCreateNativeInteface_* meant to be part of Skia-the-library or just used by testing tools? I've got it written here as tool-only, but we could easily move it to libskia if it's a thing we want to ship. I'm honestly not sure I understand how this linked before without a definition of GrGLCreateNativeInterface(). Or are there two, one real and one no-op default with some sort of weak linking setup? dlopen()? BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201233003 DOCS_PREVIEW= https://skia.org/user/quick/gn?cl=2201233003 Committed: https://skia.googlesource.com/skia/+/5259da5377a27298939fcef677851d46c75badde ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/5259da5377a27298939fcef677851d46c75badde |
