Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: public/platform/WebMediaSource.h

Issue 220123011: MSE: Remove old WebMediaSource::addSourceBuffer declaration (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/WebMediaSource.h
diff --git a/public/platform/WebMediaSource.h b/public/platform/WebMediaSource.h
index eb12c1d618c95977e60164d61e418634232f40de..702ba4c145612fdcaeae0769d28ed6a088b58d71 100644
--- a/public/platform/WebMediaSource.h
+++ b/public/platform/WebMediaSource.h
@@ -58,20 +58,7 @@ public:
};
virtual ~WebMediaSource() { }
-
- // FIXME: Remove addSourceBuffer() that has no FrameProcessorChoice, and
- // remove the default implementation for the addSourceBuffer() that has
- // FrameProcessorChoice once the latter's Chromium implementation has
- // landed. See http://crbug.com/249422.
- virtual AddStatus addSourceBuffer(const WebString& type, const WebVector<WebString>& codecs, WebSourceBuffer** webSourceBuffer)
- {
- return addSourceBuffer(type, codecs, WebMediaSource::UseLegacyFrameProcessor, webSourceBuffer);
- }
- virtual AddStatus addSourceBuffer(const WebString& type, const WebVector<WebString>& codecs, const FrameProcessorChoice choice, WebSourceBuffer** webSourceBuffer)
- {
- return addSourceBuffer(type, codecs, webSourceBuffer);
- }
-
+ virtual AddStatus addSourceBuffer(const WebString& type, const WebVector<WebString>& codecs, const FrameProcessorChoice, WebSourceBuffer**) = 0;
virtual double duration() = 0;
virtual void setDuration(double) = 0;
virtual void markEndOfStream(EndOfStreamStatus) = 0;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698