Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: Source/core/css/RuleFeature.h

Issue 220123004: Add support for element ids in TargetedStyleRecalc (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Adjust test. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/RuleFeature.h
diff --git a/Source/core/css/RuleFeature.h b/Source/core/css/RuleFeature.h
index 87ede478884d84fdc603fb6a885bdd4ccd3bf73d..394356d4b2cbe2315ea7605040dff78c557ebf26 100644
--- a/Source/core/css/RuleFeature.h
+++ b/Source/core/css/RuleFeature.h
@@ -71,18 +71,18 @@ public:
inline bool hasSelectorForAttribute(const AtomicString& attributeName) const
{
ASSERT(!attributeName.isEmpty());
- return m_attributeInvalidationSets.get(attributeName);
+ return m_attributeInvalidationSets.contains(attributeName);
}
inline bool hasSelectorForClass(const AtomicString& classValue) const
{
ASSERT(!classValue.isEmpty());
- return m_classInvalidationSets.get(classValue);
+ return m_classInvalidationSets.contains(classValue);
}
inline bool hasSelectorForId(const AtomicString& idValue) const
{
- return m_metadata.idsInRules.contains(idValue);
+ return m_idInvalidationSets.contains(idValue);
}
void scheduleStyleInvalidationForClassChange(const SpaceSplitString& changedClasses, Element&);
@@ -90,9 +90,11 @@ public:
void scheduleStyleInvalidationForAttributeChange(const QualifiedName& attributeName, Element&);
- int hasIdsInSelectors() const
+ void scheduleStyleInvalidationForIdChange(const AtomicString& oldId, const AtomicString& newId, Element&);
+
+ bool hasIdsInSelectors() const
{
- return m_metadata.idsInRules.size() > 0;
+ return m_idInvalidationSets.size() > 0;
}
// Marks the given attribute name as "appearing in a selector". Used for
@@ -120,7 +122,6 @@ private:
bool usesFirstLineRules;
bool foundSiblingSelector;
unsigned maxDirectAdjacentSelectors;
- HashSet<AtomicString> idsInRules;
};
enum InvalidationSetMode {
@@ -136,6 +137,7 @@ private:
DescendantInvalidationSet& ensureClassInvalidationSet(const AtomicString& className);
DescendantInvalidationSet& ensureAttributeInvalidationSet(const AtomicString& attributeName);
+ DescendantInvalidationSet& ensureIdInvalidationSet(const AtomicString& attributeName);
DescendantInvalidationSet* invalidationSetForSelector(const CSSSelector&);
InvalidationSetMode updateInvalidationSets(const CSSSelector&);
@@ -158,6 +160,7 @@ private:
FeatureMetadata m_metadata;
InvalidationSetMap m_classInvalidationSets;
InvalidationSetMap m_attributeInvalidationSets;
+ InvalidationSetMap m_idInvalidationSets;
bool m_targetedStyleRecalcEnabled;
StyleInvalidator m_styleInvalidator;
};
« no previous file with comments | « LayoutTests/fast/css/invalidation/targeted-id-style-invalidation-expected.txt ('k') | Source/core/css/RuleFeature.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698