Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issue 2201203003: Unified the code to upload goma-related information. (Closed)

Created:
4 years, 4 months ago by Yoshisato Yanagisawa
Modified:
4 years, 4 months ago
Reviewers:
ukai, tikuta, shinyak
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Unified the code to upload goma-related information. Committed: https://chromium.googlesource.com/chromium/tools/build/+/489cc86abae972ea7e12e81ec194b532d7a6e14f

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comment #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -45 lines) Patch
M scripts/slave/compile.py View 1 3 chunks +35 lines, -45 lines 1 comment Download

Messages

Total messages: 14 (4 generated)
Yoshisato Yanagisawa
4 years, 4 months ago (2016-08-03 04:32:51 UTC) #2
tikuta
lgtm
4 years, 4 months ago (2016-08-03 04:41:15 UTC) #3
ukai
lgtm https://codereview.chromium.org/2201203003/diff/1/scripts/slave/compile.py File scripts/slave/compile.py (right): https://codereview.chromium.org/2201203003/diff/1/scripts/slave/compile.py#newcode75 scripts/slave/compile.py:75: def StopGomaClientAndUploadInfo(options, env, exit_status): doc comment?
4 years, 4 months ago (2016-08-03 05:21:17 UTC) #4
shinyak
lgtm
4 years, 4 months ago (2016-08-03 05:34:04 UTC) #5
Yoshisato Yanagisawa
https://codereview.chromium.org/2201203003/diff/1/scripts/slave/compile.py File scripts/slave/compile.py (right): https://codereview.chromium.org/2201203003/diff/1/scripts/slave/compile.py#newcode75 scripts/slave/compile.py:75: def StopGomaClientAndUploadInfo(options, env, exit_status): On 2016/08/03 05:21:16, ukai wrote: ...
4 years, 4 months ago (2016-08-03 05:50:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2201203003/20001
4 years, 4 months ago (2016-08-03 06:04:45 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/tools/build/+/489cc86abae972ea7e12e81ec194b532d7a6e14f
4 years, 4 months ago (2016-08-03 06:09:02 UTC) #11
shinyak
failure reason is this? https://codereview.chromium.org/2201203003/diff/20001/scripts/slave/compile.py File scripts/slave/compile.py (right): https://codereview.chromium.org/2201203003/diff/20001/scripts/slave/compile.py#newcode99 scripts/slave/compile.py:99: override_gsutil = options.gsutil_py_path [sys.executable, options.gsutil_py_path] ...
4 years, 4 months ago (2016-08-03 06:31:06 UTC) #12
Yoshisato Yanagisawa
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2206933002/ by yyanagisawa@chromium.org. ...
4 years, 4 months ago (2016-08-03 06:31:18 UTC) #13
tikuta
4 years, 4 months ago (2016-08-09 03:51:03 UTC) #14
Message was sent while issue was closed.
Will you land fixed version of this CL?

Powered by Google App Engine
This is Rietveld 408576698