Unified the code to upload goma-related information.

Unified the code to upload goma-related information.

Committed: https://chromium.googlesource.com/chromium/tools/build/+/489cc86abae972ea7e12e81ec194b532d7a6e14f

[Yoshisato Yanagisawa, 2016-08-03 04:32:50]

yyanagisawa@chromium.org changed reviewers:
+ shinyak@chromium.org, tikuta@chromium.org, ukai@chromium.org

[tikuta, 2016-08-03 04:41:15]

lgtm

[ukai, 2016-08-03 05:21:17]

lgtm

https://codereview.chromium.org/2201203003/diff/1/scripts/slave/compile.py
File scripts/slave/compile.py (right):

https://codereview.chromium.org/2201203003/diff/1/scripts/slave/compile.py#ne...
scripts/slave/compile.py:75: def StopGomaClientAndUploadInfo(options, env,
exit_status):
doc comment?

[shinyak, 2016-08-03 05:34:04]

lgtm

[Yoshisato Yanagisawa, 2016-08-03 05:50:25]

https://codereview.chromium.org/2201203003/diff/1/scripts/slave/compile.py
File scripts/slave/compile.py (right):

https://codereview.chromium.org/2201203003/diff/1/scripts/slave/compile.py#ne...
scripts/slave/compile.py:75: def StopGomaClientAndUploadInfo(options, env,
exit_status):
On 2016/08/03 05:21:16, ukai wrote:
> doc comment?

Done.

[Yoshisato Yanagisawa, 2016-08-03 06:04:35]

The CQ bit was checked by yyanagisawa@chromium.org

[Yoshisato Yanagisawa, 2016-08-03 06:04:36]

The patchset sent to the CQ was uploaded after l-g-t-m from ukai@chromium.org,
tikuta@chromium.org, shinyak@chromium.org
Link to the patchset: https://codereview.chromium.org/2201203003/#ps20001
(title: "add comment")

[commit-bot: I haz the power, 2016-08-03 06:04:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 06:09:01]

Description was changed from

==========
Unified the code to upload goma-related information.
==========

to

==========
Unified the code to upload goma-related information.

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/489cc86abae972ea7e12...
==========

[commit-bot: I haz the power, 2016-08-03 06:09:02]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/489cc86abae972ea7e12...

[shinyak, 2016-08-03 06:31:06]

failure reason is this?

https://codereview.chromium.org/2201203003/diff/20001/scripts/slave/compile.py
File scripts/slave/compile.py (right):

https://codereview.chromium.org/2201203003/diff/20001/scripts/slave/compile.p...
scripts/slave/compile.py:99: override_gsutil = options.gsutil_py_path
[sys.executable, options.gsutil_py_path] ?

[Yoshisato Yanagisawa, 2016-08-03 06:31:18]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2206933002/ by yyanagisawa@chromium.org.

The reason for reverting is: broke
https://build.chromium.org/p/chromium.fyi/builders/Chromium%20Mac%2010.9%20Go....

[tikuta, 2016-08-09 03:51:03]

Will you land fixed version of this CL?