Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2201203002: Eliminate remaining case of ambiguous context level info (Closed)

Created:
4 years, 4 months ago by hausner
Modified:
4 years, 4 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Eliminate remaining case of ambiguous context level info When generating the scopes in an await-for loop, make sure the scope of the loop block is a proper sub-range of the block surrounding the loop. This eliminates the last case where the compiler generated context info of the same range, but with contradicting context level info. BUG=26941 R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/478e0db389f7132703f191cbee64ffbc0fef72a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M runtime/vm/parser.cc View 2 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
hausner
4 years, 4 months ago (2016-08-02 21:20:50 UTC) #3
regis
LGTM!
4 years, 4 months ago (2016-08-02 21:25:49 UTC) #4
hausner
4 years, 4 months ago (2016-08-02 21:44:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
478e0db389f7132703f191cbee64ffbc0fef72a1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698