src/interpreter/bytecode-generator.h - Issue 2201193004: Use Variable::binding_needs_init() to determine hole initialization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/bytecode-generator.h

Issue 2201193004: Use Variable::binding_needs_init() to determine hole initialization (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Remove one more comment Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/interpreter/bytecode-generator.h

diff --git a/src/interpreter/bytecode-generator.h b/src/interpreter/bytecode-generator.h

index ec282dd2bd63abed566d2b555f101bf7232e3d57..5d713efff5fe6abf57e1bd2f5bcefe0f118f3c7e 100644

--- a/src/interpreter/bytecode-generator.h

+++ b/src/interpreter/bytecode-generator.h

@@ -115,7 +115,7 @@ class BytecodeGenerator final : public AstVisitor<BytecodeGenerator> {

void BuildThrowIfNotHole(Handle<String> name);

void BuildThrowReassignConstant(Handle<String> name);

void BuildThrowReferenceError(Handle<String> name);

- void BuildHoleCheckForVariableLoad(VariableMode mode, Handle<String> name);

+ void BuildHoleCheckForVariableLoad(Variable* variable);

void BuildHoleCheckForVariableAssignment(Variable* variable, Token::Value op);

// Build jump to targets[value], where

« no previous file with comments | « src/full-codegen/x64/full-codegen-x64.cc ('k') | src/interpreter/bytecode-generator.cc » ('j') | no next file with comments »