Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 2201183005: Eliminate kMojoChannelToken usage for render processes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.h ('k') | content/child/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_process_host_impl.cc
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
index 9919ef63993362ed241ab62a7e52e012066e566d..d0ae9feb1af91d19da52c3b4d7cdf6b43d26c7bb 100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -165,6 +165,7 @@
#include "gpu/command_buffer/service/gpu_switches.h"
#include "ipc/attachment_broker.h"
#include "ipc/attachment_broker_privileged.h"
+#include "ipc/ipc.mojom.h"
#include "ipc/ipc_channel.h"
#include "ipc/ipc_channel_mojo.h"
#include "ipc/ipc_logging.h"
@@ -820,8 +821,7 @@ bool RenderProcessHostImpl::Init() {
g_renderer_main_thread_factory(InProcessChildThreadParams(
channel_id,
BrowserThread::GetTaskRunnerForThread(BrowserThread::IO),
- mojo_channel_token_,
- mojo_child_connection_->service_token())));
+ std::string(), mojo_child_connection_->service_token())));
base::Thread::Options options;
#if defined(OS_WIN) && !defined(OS_MACOSX)
@@ -881,12 +881,11 @@ std::unique_ptr<IPC::ChannelProxy> RenderProcessHostImpl::CreateChannelProxy(
const std::string& channel_id) {
scoped_refptr<base::SingleThreadTaskRunner> runner =
BrowserThread::GetTaskRunnerForThread(BrowserThread::IO);
- mojo_channel_token_ = mojo::edk::GenerateRandomToken();
- mojo::ScopedMessagePipeHandle handle =
- mojo::edk::CreateParentMessagePipe(mojo_channel_token_, child_token_);
-
+ IPC::mojom::ChannelBootstrapPtr bootstrap;
+ GetRemoteInterfaces()->GetInterface(&bootstrap);
std::unique_ptr<IPC::ChannelFactory> channel_factory =
- IPC::ChannelMojo::CreateServerFactory(std::move(handle), runner);
+ IPC::ChannelMojo::CreateServerFactory(
+ bootstrap.PassInterface().PassHandle(), runner);
// Do NOT expand ifdef or run time condition checks here! Synchronous
// IPCs from browser process are banned. It is only narrowly allowed
@@ -1421,10 +1420,6 @@ void RenderProcessHostImpl::AppendRendererCommandLine(
AppendCompositorCommandLineFlags(command_line);
- if (!mojo_channel_token_.empty()) {
- command_line->AppendSwitchASCII(switches::kMojoChannelToken,
- mojo_channel_token_);
- }
command_line->AppendSwitchASCII(switches::kMojoApplicationChannelToken,
mojo_child_connection_->service_token());
}
« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.h ('k') | content/child/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698