Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2201183004: Revert "Better error-message when bind fails." (Closed)

Created:
4 years, 4 months ago by rmacnak
Modified:
4 years, 4 months ago
Reviewers:
Søren Gjesse, floitsch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Better error-message when bind fails." This reverts commit 8c4954492f0593f41d270691bb82c26d8509c894. This change broke the Android build. Committed: https://github.com/dart-lang/sdk/commit/5ebcd3cda0f34be580be1a8ed816849a82691427

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -55 lines) Patch
M CHANGELOG.md View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/bin/io_natives.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/socket.h View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/bin/socket.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/bin/socket_fuchsia.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/bin/socket_linux.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/bin/socket_macos.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/bin/socket_patch.dart View 2 chunks +1 line, -8 lines 0 comments Download
M runtime/bin/socket_unsupported.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/bin/socket_win.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M tests/standalone/io/socket_source_address_test.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 4 months ago (2016-08-03 16:54:37 UTC) #2
rmacnak
Committed patchset #1 (id:1) manually as 5ebcd3cda0f34be580be1a8ed816849a82691427 (presubmit successful).
4 years, 4 months ago (2016-08-03 16:55:03 UTC) #4
floitsch
4 years, 4 months ago (2016-08-03 19:54:18 UTC) #5
Message was sent while issue was closed.
LGTM.
thanks.

Powered by Google App Engine
This is Rietveld 408576698