Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2201183002: Add a group id to PwsResult (Closed)

Created:
4 years, 4 months ago by cco3
Modified:
4 years, 4 months ago
Reviewers:
gone, mattreynolds
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a group id to PwsResult A group id is an identifier that associates URLs into buckets. (i.e., URLs from the same domain with the same title might have the same group id). In anticipation of the PWS sending Chrome a group id, this change adds a placeholder to our PwsResult data structure. BUG=633715 Committed: https://crrev.com/df58d62bc0bff46e73ffde6cd3479efd5009ad5e Cr-Commit-Position: refs/heads/master@{#409639}

Patch Set 1 #

Messages

Total messages: 12 (4 generated)
cco3
4 years, 4 months ago (2016-08-02 21:18:00 UTC) #2
cco3
Hi Matt, could you please take a look at this?
4 years, 4 months ago (2016-08-03 18:25:20 UTC) #3
mattreynolds
lgtm
4 years, 4 months ago (2016-08-03 18:29:58 UTC) #4
cco3
Hi Dan, this is a small change to add a field to one of our ...
4 years, 4 months ago (2016-08-03 21:10:52 UTC) #6
gone
lgtm
4 years, 4 months ago (2016-08-03 21:16:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2201183002/1
4 years, 4 months ago (2016-08-03 21:31:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 22:22:06 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 22:23:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df58d62bc0bff46e73ffde6cd3479efd5009ad5e
Cr-Commit-Position: refs/heads/master@{#409639}

Powered by Google App Engine
This is Rietveld 408576698