runtime/vm/isolate.cc - Issue 2201163004: Disable canonical verifier for precompiled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/isolate.cc

Issue 2201163004: Disable canonical verifier for precompiled. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/isolate.cc

diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc

index bf3b924f10a55f4152e85e76f7e6450ae988fc9a..32dc9677e6750c4dd446149ef5fa79ae41f1b008 100644

--- a/runtime/vm/isolate.cc

+++ b/runtime/vm/isolate.cc

@@ -1494,7 +1494,8 @@ static void ShutdownIsolate(uword parameter) {

ASSERT(thread->isolate() == isolate);

StackZone zone(thread);

HandleScope handle_scope(thread);

-#if defined(DEBUG)

+ // TODO(27003): Enable for precompiled.

+#if defined(DEBUG) && !defined(DART_PRECOMPILED_RUNTIME)

if (!isolate->HasAttemptedReload()) {

isolate->heap()->CollectAllGarbage();

VerifyCanonicalVisitor check_canonical(thread);

« no previous file with comments | « no previous file | no next file » | no next file with comments »