SkShaper: optionally disable harfbuzz

SkShaper: optionally disable harfbuzz

also, re-enable warnings.

motivation:  used by me for PDF testing.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201153002

Committed: https://skia.googlesource.com/skia/+/13cba49982ea3a4032dc78f2b61d7c1968d4b8eb

[hal.canary, 2016-08-02 18:30:49]

Description was changed from

==========
SkShaper: optionally diable harfbuzz

BUG=skia:
==========

to

==========
SkShaper: optionally diable harfbuzz

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201153002
==========

[hal.canary, 2016-08-02 18:30:58]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 18:31:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hal.canary, 2016-08-02 18:31:23]

Description was changed from

==========
SkShaper: optionally diable harfbuzz

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201153002
==========

to

==========
SkShaper: optionally diable harfbuzz

motivation:  used by me for PDF testing.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201153002
==========

[hal.canary, 2016-08-02 18:31:35]

Description was changed from

==========
SkShaper: optionally diable harfbuzz

motivation:  used by me for PDF testing.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201153002
==========

to

==========
SkShaper: optionally disable harfbuzz

motivation:  used by me for PDF testing.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201153002
==========

[commit-bot: I haz the power, 2016-08-02 18:39:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 18:39:57]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on master.client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[hal.canary, 2016-08-02 20:50:13]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 20:50:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hal.canary, 2016-08-02 20:50:32]

Description was changed from

==========
SkShaper: optionally disable harfbuzz

motivation:  used by me for PDF testing.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201153002
==========

to

==========
SkShaper: optionally disable harfbuzz

also, re-enable warnings.

motivation:  used by me for PDF testing.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201153002
==========

[commit-bot: I haz the power, 2016-08-02 21:10:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 21:10:15]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on master.client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)

[hal.canary, 2016-08-02 21:14:08]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 21:14:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hal.canary, 2016-08-02 21:14:14]

Patchset #2 (id:20001) has been deleted

[hal.canary, 2016-08-02 21:14:19]

Patchset #1 (id:1) has been deleted

[hal.canary, 2016-08-02 21:31:27]

halcanary@google.com changed reviewers:
+ bungeman@google.com

[hal.canary, 2016-08-02 21:31:27]

please rubberstamp

[commit-bot: I haz the power, 2016-08-02 21:31:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 21:31:51]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on master.client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[bungeman-skia, 2016-08-02 21:38:37]

https://codereview.chromium.org/2201153002/diff/40001/tools/SkShaper.cpp
File tools/SkShaper.cpp (right):

https://codereview.chromium.org/2201153002/diff/40001/tools/SkShaper.cpp#newc...
tools/SkShaper.cpp:12: #ifdef SK_ENABLE_HARFBUZZ
I know it's a bit more work, but these two implementations appear to share no
code. Can we remove this define, make this current file SkShaper_harfbuzz.cpp,
put the new code in SkShaper_primitive.cpp, and then let the build file pick one
or the other?

[hal.canary, 2016-08-02 22:28:13]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 22:28:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 22:51:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 22:51:45]

Dry run: This issue passed the CQ dry run.

[hal.canary, 2016-08-02 23:00:45]

https://codereview.chromium.org/2201153002/diff/40001/tools/SkShaper.cpp
File tools/SkShaper.cpp (right):

https://codereview.chromium.org/2201153002/diff/40001/tools/SkShaper.cpp#newc...
tools/SkShaper.cpp:12: #ifdef SK_ENABLE_HARFBUZZ
On 2016/08/02 21:38:36, bungeman-skia wrote:
> I know it's a bit more work, but these two implementations appear to share no
> code. Can we remove this define, make this current file SkShaper_harfbuzz.cpp,
> put the new code in SkShaper_primitive.cpp, and then let the build file pick
one
> or the other?

Done.

[bungeman-skia, 2016-08-03 14:51:37]

lgtm

[hal.canary, 2016-08-03 17:42:50]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2016-08-03 17:43:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 17:43:57]

Description was changed from

==========
SkShaper: optionally disable harfbuzz

also, re-enable warnings.

motivation:  used by me for PDF testing.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201153002
==========

to

==========
SkShaper: optionally disable harfbuzz

also, re-enable warnings.

motivation:  used by me for PDF testing.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201153002

Committed:
https://skia.googlesource.com/skia/+/13cba49982ea3a4032dc78f2b61d7c1968d4b8eb
==========

[commit-bot: I haz the power, 2016-08-03 17:43:58]

Committed patchset #2 (id:60001) as
https://skia.googlesource.com/skia/+/13cba49982ea3a4032dc78f2b61d7c1968d4b8eb