Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 220113012: Refactor CalculateConfidence and add unit test. (Closed)

Created:
6 years, 8 months ago by qyearsley
Modified:
6 years, 8 months ago
Reviewers:
shatch, prasadv
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Refactor CalculateConfidence and add unit test. This version is a little bit different from the last; main differences: - I saw that the "CalculateBounds" was returning the minimum and maximum of the means of the input list, so I thought it would be easier to understand if this was done by mapping CalculateMean and then directly making a tuple with min/max. - Since CalculateTruncatedMean(xs, 0) is just the mean, and this is used in several place, I extracted out a convenience function CalculateMean. - CalculateConfidence doesn't refer to self, so I thought it was reasonable to move it up to be a top-level function with the other stats functions. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262924

Patch Set 1 #

Patch Set 2 : Update call-site of CalculateConfidence. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -49 lines) Patch
M tools/bisect-perf-regression.py View 1 7 chunks +74 lines, -49 lines 0 comments Download
A tools/bisect-perf-regression_test.py View 1 chunk +79 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
qyearsley
6 years, 8 months ago (2014-04-07 20:14:53 UTC) #1
shatch
Really liking the refactor work! Script is becoming more readable :) The tests are something ...
6 years, 8 months ago (2014-04-08 19:59:06 UTC) #2
prasadv
lgtm
6 years, 8 months ago (2014-04-09 23:21:11 UTC) #3
qyearsley
The CQ bit was checked by qyearsley@chromium.org
6 years, 8 months ago (2014-04-10 00:18:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qyearsley@chromium.org/220113012/20001
6 years, 8 months ago (2014-04-10 00:18:57 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 05:10:19 UTC) #6
Message was sent while issue was closed.
Change committed as 262924

Powered by Google App Engine
This is Rietveld 408576698