Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 220113008: Make sure advancing non-zero time delta for mock timer in testScrollLatencyFromTimeline (Closed)

Created:
6 years, 8 months ago by Yufeng Shen (Slow to review)
Modified:
6 years, 8 months ago
Reviewers:
ernstm
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Make sure advancing non-zero time delta for mock timer in testScrollLatencyFromTimeline This is a speculative fix for the flaky test RenderingStatsUnitTest.testScrollLatencyFromTimeline (crbug.com/358673) I am not sure about the root cause and can't repro this locally. Buy inspecting the code I feel there could be problems if the default timer.Advance() advances 0ms. So lets always pass in explicit low & high parameters into timer.Advance(low, high) and see if this fix the flaky test. Note: the root cause could have been fixed by https://src.chromium.org/viewvc/chrome?revision=261034&view=revision This is CL could be just a nice add-on. BUG=358673 TEST=unittests RenderingStatsUnitTest.* pass. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261464

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M tools/perf/metrics/rendering_stats_unittest.py View 1 11 chunks +15 lines, -14 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Yufeng Shen (Slow to review)
6 years, 8 months ago (2014-04-01 22:05:19 UTC) #1
ernstm
On 2014/04/01 22:05:19, Yufeng Shen wrote: Please wait until https://codereview.chromium.org/221353002/ has landed and make your ...
6 years, 8 months ago (2014-04-01 23:10:11 UTC) #2
Yufeng Shen (Slow to review)
On 2014/04/01 23:10:11, ernstm wrote: > On 2014/04/01 22:05:19, Yufeng Shen wrote: > > Please ...
6 years, 8 months ago (2014-04-02 18:00:11 UTC) #3
ernstm
On 2014/04/02 18:00:11, Yufeng Shen wrote: > On 2014/04/01 23:10:11, ernstm wrote: > > On ...
6 years, 8 months ago (2014-04-02 23:12:08 UTC) #4
Yufeng Shen (Slow to review)
The CQ bit was checked by miletus@chromium.org
6 years, 8 months ago (2014-04-03 00:43:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miletus@chromium.org/220113008/20001
6 years, 8 months ago (2014-04-03 00:45:54 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 01:00:23 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_compile_dbg
6 years, 8 months ago (2014-04-03 01:00:24 UTC) #8
Yufeng Shen (Slow to review)
The CQ bit was checked by miletus@chromium.org
6 years, 8 months ago (2014-04-03 03:02:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miletus@chromium.org/220113008/20001
6 years, 8 months ago (2014-04-03 03:06:29 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 08:32:59 UTC) #11
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 08:32:59 UTC) #12
Yufeng Shen (Slow to review)
The CQ bit was checked by miletus@chromium.org
6 years, 8 months ago (2014-04-03 17:25:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miletus@chromium.org/220113008/20001
6 years, 8 months ago (2014-04-03 17:26:52 UTC) #14
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 17:28:14 UTC) #15
Message was sent while issue was closed.
Change committed as 261464

Powered by Google App Engine
This is Rietveld 408576698