Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 220113006: Followup to CSSTokenizer memory usage optimization (Closed)

Created:
6 years, 8 months ago by Daniel Bratell
Modified:
6 years, 8 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Followup to CSSTokenizer memory usage optimization Make sure to measure the same input string as we're going to parse. BUG=358667, 352544 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170636

Patch Set 1 #

Patch Set 2 : Added test #

Patch Set 3 : Fixing whitespace in test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
A LayoutTests/fast/css/css-escaped-identifier-crash.html View 1 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/css-escaped-identifier-crash-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSTokenizer-in.cpp View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Daniel Bratell
Of course I had an ugly bug in that optimization. Sorry. :-( jchaffraix, can you ...
6 years, 8 months ago (2014-04-01 17:02:20 UTC) #1
eseidel
Test?
6 years, 8 months ago (2014-04-01 17:12:52 UTC) #2
eseidel
lgtm
6 years, 8 months ago (2014-04-01 19:33:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bratell@opera.com/220113006/10001
6 years, 8 months ago (2014-04-01 19:33:37 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 20:10:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 8 months ago (2014-04-01 20:10:14 UTC) #6
Daniel Bratell
The CQ bit was checked by bratell@opera.com
6 years, 8 months ago (2014-04-01 21:56:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bratell@opera.com/220113006/30001
6 years, 8 months ago (2014-04-01 22:16:00 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 22:21:07 UTC) #9
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
6 years, 8 months ago (2014-04-01 22:21:08 UTC) #10
inferno
The CQ bit was checked by inferno@chromium.org
6 years, 8 months ago (2014-04-02 03:27:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bratell@opera.com/220113006/30001
6 years, 8 months ago (2014-04-02 03:27:29 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 05:43:38 UTC) #13
Message was sent while issue was closed.
Change committed as 170636

Powered by Google App Engine
This is Rietveld 408576698