runtime/vm/heap.cc - Issue 220113004: Trigger old-space GC when scavange made the external heap of old-space larger than max old-space si…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/heap.cc

Issue 220113004: Trigger old-space GC when scavange made the external heap of old-space larger than max old-space si… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Cleanup code. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/heap.cc

diff --git a/runtime/vm/heap.cc b/runtime/vm/heap.cc

index 835139a9cbcedeb64b23601bb8b651bb804dc549..6660f5a0f27f6db8bc31b843258886f63b127bac 100644

--- a/runtime/vm/heap.cc

+++ b/runtime/vm/heap.cc

@@ -214,7 +214,7 @@ void Heap::CollectGarbage(Space space, ApiCallbacks api_callbacks) {

new_space_->Scavenge(invoke_api_callbacks);

RecordAfterGC();

PrintStats();

- if (new_space_->HadPromotionFailure()) {

+ if (new_space_->HadPromotionFailure() || old_space_->NeedExternalGC()) {

// Old collections should call the API callbacks.

CollectGarbage(kOld, kInvokeApiCallbacks);

}

« no previous file with comments | « no previous file | runtime/vm/pages.h » ('j') | no next file with comments »