Mojo: Implement MojoUnmapBuffer().

Mojo: Implement MojoUnmapBuffer().

Still to do: more tests.

R=darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260832

[viettrungluu, 2014-03-31 23:12:21]

(Dependent on https://codereview.chromium.org/219023010/.)

[darin (slow to review), 2014-03-31 23:40:12]

LGTM

https://codereview.chromium.org/220113003/diff/1/mojo/system/mapping_table.cc
File mojo/system/mapping_table.cc (right):

https://codereview.chromium.org/220113003/diff/1/mojo/system/mapping_table.cc...
mojo/system/mapping_table.cc:41: delete it->second;
micro-nit: might want to do the .erase() call before running the destructor of
RawSharedBufferMapping as that is slightly foreign code (might have
side-effects). just something i'm probably needlessly pendantic about :-/

[viettrungluu, 2014-04-01 00:11:12]

Thanks.

On 2014/03/31 23:40:12, darin wrote:
> LGTM
> 
> https://codereview.chromium.org/220113003/diff/1/mojo/system/mapping_table.cc
> File mojo/system/mapping_table.cc (right):
> 
>
https://codereview.chromium.org/220113003/diff/1/mojo/system/mapping_table.cc...
> mojo/system/mapping_table.cc:41: delete it->second;
> micro-nit: might want to do the .erase() call before running the destructor of
> RawSharedBufferMapping as that is slightly foreign code (might have
> side-effects). just something i'm probably needlessly pendantic about :-/

Done. (I was going to do that originally, but I was too lazy to introduce the
temporary variable.)

[viettrungluu, 2014-04-01 06:05:27]

The CQ bit was checked by viettrungluu@chromium.org

[commit-bot: I haz the power, 2014-04-01 06:05:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/220113003/40001

[commit-bot: I haz the power, 2014-04-01 11:20:14]

Change committed as 260832