content/renderer/media/webmediasource_impl.h - Issue 220113002: MSE: Pick frame processor in ChunkDemuxer::AddId; prepare unit tests to pick processor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webmediasource_impl.h

Issue 220113002: MSE: Pick frame processor in ChunkDemuxer::AddId; prepare unit tests to pick processor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments: refactored to land after Blink change https://codereview.chromium.org/220593010 Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/webmediasource_impl.h

diff --git a/content/renderer/media/webmediasource_impl.h b/content/renderer/media/webmediasource_impl.h

index 42d5eef9405b5f92c846d8caad605eb82161d7d5..e9dae1b4d858f4421232d40bc5d403300ef3efe6 100644

--- a/content/renderer/media/webmediasource_impl.h

+++ b/content/renderer/media/webmediasource_impl.h

@@ -26,11 +26,12 @@ class WebMediaSourceImpl : public blink::WebMediaSource {

virtual AddStatus addSourceBuffer(

const blink::WebString& type,

const blink::WebVector<blink::WebString>& codecs,

- blink::WebSourceBuffer** source_buffer) OVERRIDE;

- virtual double duration() OVERRIDE;

- virtual void setDuration(double duration) OVERRIDE;

- virtual void markEndOfStream(EndOfStreamStatus status) OVERRIDE;

- virtual void unmarkEndOfStream() OVERRIDE;

+ const FrameProcessorChoice frame_processor_choice,

+ blink::WebSourceBuffer** source_buffer);

+ virtual double duration();

+ virtual void setDuration(double duration);

+ virtual void markEndOfStream(EndOfStreamStatus status);

+ virtual void unmarkEndOfStream();

private:

media::ChunkDemuxer* demuxer_; // Owned by WebMediaPlayerImpl.

« no previous file with comments | « no previous file | content/renderer/media/webmediasource_impl.cc » ('j') | content/renderer/media/webmediasource_impl.cc » ('J')