Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2201113002: [api] Fix IsSimpleInstantion check in InstantiatObject (Closed)

Created:
4 years, 4 months ago by Camillo Bruni
Modified:
4 years, 4 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Fix IsSimpleInstantion check in InstantiatObject We have a simple instantiation at hand if the new.target is from the same context, not the other way around. BUG=chromium:630217 Committed: https://crrev.com/60f9e60be0fc0ef4c767365d163fc373c0bda604 Cr-Commit-Position: refs/heads/master@{#38279}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/api-natives.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Camillo Bruni
PTAL
4 years, 4 months ago (2016-08-02 15:59:38 UTC) #2
Toon Verwaest
lgtm
4 years, 4 months ago (2016-08-02 20:35:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2201113002/1
4 years, 4 months ago (2016-08-03 07:30:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 07:49:27 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 07:52:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60f9e60be0fc0ef4c767365d163fc373c0bda604
Cr-Commit-Position: refs/heads/master@{#38279}

Powered by Google App Engine
This is Rietveld 408576698