Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Issue 2201093004: Rename internal ParseLazy to DoParseLazy to match DoParseProgram (Closed)

Created:
4 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 4 months ago
Reviewers:
Toon Verwaest, adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Rename internal ParseLazy to DoParseLazy to match DoParseProgram R=verwaest@chromium.org BUG= Committed: https://crrev.com/46f98c7154ffbd8f93d4a94556123027584ae638 Cr-Commit-Position: refs/heads/master@{#38310}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/parsing/parser.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/parsing/parser.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
jochen (gone - plz use gerrit)
4 years, 4 months ago (2016-08-03 13:25:05 UTC) #1
Toon Verwaest
lgtm but not a parsing owner :)
4 years, 4 months ago (2016-08-03 13:34:22 UTC) #4
jochen (gone - plz use gerrit)
Adam, mind taking a look please?
4 years, 4 months ago (2016-08-03 13:37:27 UTC) #6
adamk
lgtm
4 years, 4 months ago (2016-08-03 17:20:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2201093004/1
4 years, 4 months ago (2016-08-03 17:26:10 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 17:28:11 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 17:31:10 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46f98c7154ffbd8f93d4a94556123027584ae638
Cr-Commit-Position: refs/heads/master@{#38310}

Powered by Google App Engine
This is Rietveld 408576698