NoStatePrefetch: Add a more dummy prerender_test_server.py

NoStatePrefetch: Add a more dummy prerender_test_server.py

This local tool copies the functionality of http://prerender-test.appspot.com
and disables detection of Prerendering (via observing localStorage changes on
the same page).

It should help manually testing an alternative implementation of <link
rel=prerender>.

BUG=632361
Committed: https://crrev.com/9734b9174c55cd88adc6697dcece15a34e96901a
Cr-Commit-Position: refs/heads/master@{#410336}

[pasko, 2016-08-02 17:18:26]

Description was changed from

==========
NoStatePrefetch: Add a more dummy prerender_test.py

This local tool copies the functionality of http://prerender-test.appspot.com
and disables detection of Prerendering (via observing localStorage changes on
the same page).

It should help manually testing an alternative implementation of <link
rel=prerender>.

BUG=632361
TBR=dpranke@chromium.org
==========

to

==========
NoStatePrefetch: Add a more dummy prerender_test.py

This local tool copies the functionality of http://prerender-test.appspot.com
and disables detection of Prerendering (via observing localStorage changes on
the same page).

It should help manually testing an alternative implementation of <link
rel=prerender>.

BUG=632361
TBR=dpranke@chromium.org
==========

[pasko, 2016-08-02 17:18:26]

pasko@chromium.org changed reviewers:
+ droger@chromium.org

[pasko, 2016-08-02 17:19:55]

droger, mattcary: please review

[Dirk Pranke, 2016-08-03 00:10:03]

Is this really the best place for this, rather than in a test directory under a
source dir?

[mattcary, 2016-08-03 07:48:52]

mattcary@chromium.org changed reviewers:
+ mattcary@chromium.org

[mattcary, 2016-08-03 07:48:53]

lgtm

Modulo which directory to put this in, to which I'm indifferent.

[pasko, 2016-08-03 11:05:05]

On 2016/08/03 00:10:03, Dirk Pranke wrote:
> Is this really the best place for this, rather than in a test directory under
a
> source dir?

Oh, there are so many places. I do not fully understand the naming principles.
Are you concerned with too many things in src/tools?

Are you suggesting src/testing or something like
src/chrome/browser/prerender/test (this latter does not exist yet)?

If one of the above sound better for you, I'll take whichever you prefer, also
please mention why it is better so that I can avoid making the same mistake in
the future.

[pasko, 2016-08-04 11:42:00]

dpranke: can you respond to this with your preference please?

On 2016/08/03 11:05:05, pasko wrote:
> On 2016/08/03 00:10:03, Dirk Pranke wrote:
> > Is this really the best place for this, rather than in a test directory
under
> a
> > source dir?
> 
> Oh, there are so many places. I do not fully understand the naming principles.
> Are you concerned with too many things in src/tools?
> 
> Are you suggesting src/testing or something like
> src/chrome/browser/prerender/test (this latter does not exist yet)?
> 
> If one of the above sound better for you, I'll take whichever you prefer, also
> please mention why it is better so that I can avoid making the same mistake in
> the future.

[Dirk Pranke, 2016-08-04 15:55:08]

On 2016/08/04 11:42:00, pasko wrote:
> dpranke: can you respond to this with your preference please?
> 
> On 2016/08/03 11:05:05, pasko wrote:
> > On 2016/08/03 00:10:03, Dirk Pranke wrote:
> > > Is this really the best place for this, rather than in a test directory
> under
> > a
> > > source dir?
> > 
> > Oh, there are so many places. I do not fully understand the naming
principles.
> > Are you concerned with too many things in src/tools?
> > 
> > Are you suggesting src/testing or something like
> > src/chrome/browser/prerender/test (this latter does not exist yet)?
> > 
> > If one of the above sound better for you, I'll take whichever you prefer,
also
> > please mention why it is better so that I can avoid making the same mistake
in
> > the future.

Sorry, I missed the updates. I'd probably put it someplace under
//chrome/browse/prerender/test, as you
say. The reason for this is so that we can keep tools and tests nearer to the
code that needs them, particularly
since this is really test code, not a generic tool.

[pasko, 2016-08-05 13:22:34]

On 2016/08/04 15:55:08, Dirk Pranke wrote:
> On 2016/08/04 11:42:00, pasko wrote:
> > dpranke: can you respond to this with your preference please?
> > 
> > On 2016/08/03 11:05:05, pasko wrote:
> > > On 2016/08/03 00:10:03, Dirk Pranke wrote:
> > > > Is this really the best place for this, rather than in a test directory
> > under
> > > a
> > > > source dir?
> > > 
> > > Oh, there are so many places. I do not fully understand the naming
> principles.
> > > Are you concerned with too many things in src/tools?
> > > 
> > > Are you suggesting src/testing or something like
> > > src/chrome/browser/prerender/test (this latter does not exist yet)?
> > > 
> > > If one of the above sound better for you, I'll take whichever you prefer,
> also
> > > please mention why it is better so that I can avoid making the same
mistake
> in
> > > the future.
> 
> Sorry, I missed the updates. I'd probably put it someplace under
> //chrome/browse/prerender/test, as you
> say. The reason for this is so that we can keep tools and tests nearer to the
> code that needs them, particularly
> since this is really test code, not a generic tool.

thanks, renamed, please let me know if you want to review it besides the new
OWNERS review

[pasko, 2016-08-05 13:24:23]

pasko@chromium.org changed reviewers:
+ mmenke@chromium.org

[pasko, 2016-08-05 13:24:23]

mmenke@chromium.org: please take a look

the script has been helpful in testing our Prefetch prototype, the name might be
annoyingly non-creative, I am warmly welcoming warm suggestions.

[mmenke, 2016-08-05 14:55:34]

On 2016/08/05 13:24:23, pasko wrote:
> mailto:mmenke@chromium.org: please take a look
> 
> the script has been helpful in testing our Prefetch prototype, the name might
be
> annoyingly non-creative, I am warmly welcoming warm suggestions.

Maybe /test/prerender_test/ -> /tools/prerender_[test_]server/?

/tools/ to make it clearer that this is automatic testing intrastructure,
prerender_server to indicate exactly how it's used.  Modulo naming, LGTM.

[mmenke, 2016-08-05 15:04:24]

On 2016/08/05 14:55:34, mmenke wrote:
> On 2016/08/05 13:24:23, pasko wrote:
> > mailto:mmenke@chromium.org: please take a look
> > 
> > the script has been helpful in testing our Prefetch prototype, the name
might
> be
> > annoyingly non-creative, I am warmly welcoming warm suggestions.
> 
> Maybe /test/prerender_test/ -> /tools/prerender_[test_]server/?
> 
> /tools/ to make it clearer that this is automatic testing intrastructure,
> prerender_server to indicate exactly how it's used.  Modulo naming, LGTM.

Clearer this is *not* automatic testing infrastructure

[pasko, 2016-08-08 12:32:20]

Description was changed from

==========
NoStatePrefetch: Add a more dummy prerender_test.py

This local tool copies the functionality of http://prerender-test.appspot.com
and disables detection of Prerendering (via observing localStorage changes on
the same page).

It should help manually testing an alternative implementation of <link
rel=prerender>.

BUG=632361
TBR=dpranke@chromium.org
==========

to

==========
NoStatePrefetch: Add a more dummy prerender_test_server.py

This local tool copies the functionality of http://prerender-test.appspot.com
and disables detection of Prerendering (via observing localStorage changes on
the same page).

It should help manually testing an alternative implementation of <link
rel=prerender>.

BUG=632361
==========

[pasko, 2016-08-08 12:33:30]

The CQ bit was checked by pasko@chromium.org

[pasko, 2016-08-08 12:33:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
mattcary@chromium.org, mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/2201093003/#ps40001
(title: "Renamed to tools/prerender_test_server/prerender_test_server.py")

[commit-bot: I haz the power, 2016-08-08 12:33:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 13:12:38]

Description was changed from

==========
NoStatePrefetch: Add a more dummy prerender_test_server.py

This local tool copies the functionality of http://prerender-test.appspot.com
and disables detection of Prerendering (via observing localStorage changes on
the same page).

It should help manually testing an alternative implementation of <link
rel=prerender>.

BUG=632361
==========

to

==========
NoStatePrefetch: Add a more dummy prerender_test_server.py

This local tool copies the functionality of http://prerender-test.appspot.com
and disables detection of Prerendering (via observing localStorage changes on
the same page).

It should help manually testing an alternative implementation of <link
rel=prerender>.

BUG=632361
==========

[commit-bot: I haz the power, 2016-08-08 13:12:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-08 13:14:44]

Description was changed from

==========
NoStatePrefetch: Add a more dummy prerender_test_server.py

This local tool copies the functionality of http://prerender-test.appspot.com
and disables detection of Prerendering (via observing localStorage changes on
the same page).

It should help manually testing an alternative implementation of <link
rel=prerender>.

BUG=632361
==========

to

==========
NoStatePrefetch: Add a more dummy prerender_test_server.py

This local tool copies the functionality of http://prerender-test.appspot.com
and disables detection of Prerendering (via observing localStorage changes on
the same page).

It should help manually testing an alternative implementation of <link
rel=prerender>.

BUG=632361

Committed: https://crrev.com/9734b9174c55cd88adc6697dcece15a34e96901a
Cr-Commit-Position: refs/heads/master@{#410336}
==========

[commit-bot: I haz the power, 2016-08-08 13:14:46]

Patchset 3 (id:??) landed as
https://crrev.com/9734b9174c55cd88adc6697dcece15a34e96901a
Cr-Commit-Position: refs/heads/master@{#410336}

[pasko, 2016-08-08 13:37:09]

On 2016/08/05 14:55:34, mmenke wrote:
> On 2016/08/05 13:24:23, pasko wrote:
> > mailto:mmenke@chromium.org: please take a look
> > 
> > the script has been helpful in testing our Prefetch prototype, the name
might
> be
> > annoyingly non-creative, I am warmly welcoming warm suggestions.
> 
> Maybe /test/prerender_test/ -> /tools/prerender_[test_]server/?
> 
> /tools/ to make it clearer that this is automatic testing intrastructure,
> prerender_server to indicate exactly how it's used.  Modulo naming, LGTM.

forgot to say: thanks for suggestion, Matt! Done.

[Dirk Pranke, 2016-08-08 20:39:46]

lgtm