Make all reload zone allocations use the same zone

Make all reload zone allocations use the same zone

- [x] Use a single outer zone for all zone allocations done during a reload. This fixes an issue where we were allocating  objects in different zones that were destroyed before we expected them to be.
- [x] Rename some methods.
- [x] Made most methods on IsolateReloadContext private.

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/059470cf8576078f71abe1255add76d1f4680356

[Cutch, 2016-08-02 15:05:10]

Description was changed from

==========
Make all reload zone allocations use the same zone

BUG=
==========

to

==========
Make all reload zone allocations use the same zone

- [x] Use a single outer zone for all zone allocations done during a reload.
This fixes an issue where we were allocating  objects in different zones that
were destroyed before we expected them to be.
- [x] Rename some methods.
- [x] Made most methods on IsolateReloadContext private.
==========

[Cutch, 2016-08-02 15:05:11]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2016-08-02 16:30:22]

lgtm

https://chromiumcodereview.appspot.com/2201093002/diff/1/runtime/vm/isolate_r...
File runtime/vm/isolate_reload.cc (right):

https://chromiumcodereview.appspot.com/2201093002/diff/1/runtime/vm/isolate_r...
runtime/vm/isolate_reload.cc:433: fprintf(stderr, "Reload\n");
Remove

https://chromiumcodereview.appspot.com/2201093002/diff/1/runtime/vm/isolate_r...
runtime/vm/isolate_reload.cc:530: fprintf(stderr, "FinalizeLoading\n");
"

[Cutch, 2016-08-02 16:32:33]

https://chromiumcodereview.appspot.com/2201093002/diff/1/runtime/vm/isolate_r...
File runtime/vm/isolate_reload.cc (right):

https://chromiumcodereview.appspot.com/2201093002/diff/1/runtime/vm/isolate_r...
runtime/vm/isolate_reload.cc:433: fprintf(stderr, "Reload\n");
On 2016/08/02 16:30:22, rmacnak wrote:
> Remove

Done.

https://chromiumcodereview.appspot.com/2201093002/diff/1/runtime/vm/isolate_r...
runtime/vm/isolate_reload.cc:530: fprintf(stderr, "FinalizeLoading\n");
On 2016/08/02 16:30:22, rmacnak wrote:
> "

Done.

[Cutch, 2016-08-02 16:36:51]

Description was changed from

==========
Make all reload zone allocations use the same zone

- [x] Use a single outer zone for all zone allocations done during a reload.
This fixes an issue where we were allocating  objects in different zones that
were destroyed before we expected them to be.
- [x] Rename some methods.
- [x] Made most methods on IsolateReloadContext private.
==========

to

==========
Make all reload zone allocations use the same zone

- [x] Use a single outer zone for all zone allocations done during a reload.
This fixes an issue where we were allocating  objects in different zones that
were destroyed before we expected them to be.
- [x] Rename some methods.
- [x] Made most methods on IsolateReloadContext private.

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/059470cf8576078f71abe1255add76d1f4680356
==========

[Cutch, 2016-08-02 16:36:53]

Committed patchset #3 (id:40001) manually as
059470cf8576078f71abe1255add76d1f4680356 (presubmit successful).