Improved accessibility of treeview control used in internal pages.

Improved accessibility of treeview control used in internal pages.

1. Added accessibility label for each tree item. Without it the accessible label was automatically computed by concatenating the text in all the children: a non-sensical output.
2. Added group role for children which enables screen readers to announce the current level in the tree.
3. Added aria-expanded for tree items with children.
R=dmazzoni@chromium.org, thakis@chromium.org
TESTED=Manually with Jaws and NVDA
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/2a282cecab19f84128c0bb12f5fe1d9dd0f4c87a
Cr-Commit-Position: refs/heads/master@{#410414}

[nektarios, 2016-08-03 01:44:20]

Description was changed from

==========
Improved accessibility of treeview control used in internal pages.

1. Added accessibility label for each tree item. Without it the accessible label
was automatically computed by concatenating the text in all the children: a
non-sensical output.
2. Added group role for children which enables screen readers to announce the
current level in the tree.
3. Added aria-expanded for tree items with children.
R=dmazzoni@chromium.org, thakis@chromium.org
TESTED=Manually with Jaws and NVDA
==========

to

==========
Improved accessibility of treeview control used in internal pages.

1. Added accessibility label for each tree item. Without it the accessible label
was automatically computed by concatenating the text in all the children: a
non-sensical output.
2. Added group role for children which enables screen readers to announce the
current level in the tree.
3. Added aria-expanded for tree items with children.
R=dmazzoni@chromium.org, thakis@chromium.org
TESTED=Manually with Jaws and NVDA
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[nektarios, 2016-08-03 15:55:20]

nektar@chromium.org changed reviewers:
+ dpapad@chromium.org

[dpapad, 2016-08-03 20:31:19]

https://codereview.chromium.org/2201033004/diff/1/ui/webui/resources/js/cr/ui...
File ui/webui/resources/js/cr/ui/tree.js (right):

https://codereview.chromium.org/2201033004/diff/1/ui/webui/resources/js/cr/ui...
ui/webui/resources/js/cr/ui/tree.js:259: '<div class=tree-children
role=group></div>';
All those class= statements are missing quotes, should be

class="expand-icon"
class="tree-label"
class="tree-children"
role="group"

https://codereview.chromium.org/2201033004/diff/1/ui/webui/resources/js/cr/ui...
ui/webui/resources/js/cr/ui/tree.js:412: if (this.mayHaveChildren_) {
Nit: No need for curly braces.

[nektarios, 2016-08-03 22:35:56]

All fixed.

[dpapad, 2016-08-03 22:46:10]

LGTM, for JS style. Not familiar with the accessibility APIs though.

[nektarios, 2016-08-08 19:21:03]

The CQ bit was checked by nektar@chromium.org

[commit-bot: I haz the power, 2016-08-08 19:21:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 20:09:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-08 20:11:16]

Description was changed from

==========
Improved accessibility of treeview control used in internal pages.

1. Added accessibility label for each tree item. Without it the accessible label
was automatically computed by concatenating the text in all the children: a
non-sensical output.
2. Added group role for children which enables screen readers to announce the
current level in the tree.
3. Added aria-expanded for tree items with children.
R=dmazzoni@chromium.org, thakis@chromium.org
TESTED=Manually with Jaws and NVDA
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Improved accessibility of treeview control used in internal pages.

1. Added accessibility label for each tree item. Without it the accessible label
was automatically computed by concatenating the text in all the children: a
non-sensical output.
2. Added group role for children which enables screen readers to announce the
current level in the tree.
3. Added aria-expanded for tree items with children.
R=dmazzoni@chromium.org, thakis@chromium.org
TESTED=Manually with Jaws and NVDA
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/2a282cecab19f84128c0bb12f5fe1d9dd0f4c87a
Cr-Commit-Position: refs/heads/master@{#410414}
==========

[commit-bot: I haz the power, 2016-08-08 20:11:20]

Patchset 2 (id:??) landed as
https://crrev.com/2a282cecab19f84128c0bb12f5fe1d9dd0f4c87a
Cr-Commit-Position: refs/heads/master@{#410414}

[dmazzoni, 2016-08-08 20:24:25]

lgtm with one possible bug

https://codereview.chromium.org/2201033004/diff/20001/ui/webui/resources/js/c...
File ui/webui/resources/js/cr/ui/tree.js (right):

https://codereview.chromium.org/2201033004/diff/20001/ui/webui/resources/js/c...
ui/webui/resources/js/cr/ui/tree.js:284: treeItemAutoGeneratedIdCounter;
I think you need to increment this?

[chromium-reviews, 2016-08-08 21:22:32]

>
https://codereview.chromium.org/2201033004/diff/20001/ui/webui/resources/js/c...
> ui/webui/resources/js/cr/ui/tree.js:284: treeItemAutoGeneratedIdCounter;
> I think you need to increment this?

It is incremented when a new tree item is added. The tree item gets an 
ID like "tree-item-id-5".
I wanted to use the same number for the tree item's label. Something 
like "tree-item-label-id-5". So, I didn't increment.
The label is a child of the tree item.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.