Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2201033002:
[test] Fix joining FAIL expectations in status files (Closed)
|
Created:
4 years, 4 months ago by Michael Achenbach Modified:
4 years, 4 months ago CC:
v8-reviews_googlegroups.com, mvstanton Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[test] Fix joining FAIL expectations in status files
Without this fix, two rules [PASS, MODIFIER] and [FAIL]
would be joined as [PASS, MODIFIER, FAIL], undermining the
intention of the second rule to mark a test as failing.
BUG=v8:4680, v8:4900
Committed: https://crrev.com/8552e6822317c48638eb25d71c902cffebee21f1
Cr-Commit-Position: refs/heads/master@{#38238}
Patch Set 1 #Patch Set 2 : Remove expectations for tests that no longer fail #Patch Set 3 : Rebase #
Messages
Total messages: 24 (19 generated)
machenbach@chromium.org changed reviewers: + jkummerow@chromium.org, mstarzinger@chromium.org
PTAL
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [test] Fix joining FAIL expectations in status files BUG= ========== to ========== [test] Fix joining FAIL expectations in status files Without this fix, two rules [PASS, MODIFIER] and [FAIL] would be joined as [PASS, MODIFIER, FAIL], undermining the intention of the second rule to mark a test as failing. ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...) v8_linux_nodcheck_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng_tr...) v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...) v8_win_nosnap_shared_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [test] Fix joining FAIL expectations in status files Without this fix, two rules [PASS, MODIFIER] and [FAIL] would be joined as [PASS, MODIFIER, FAIL], undermining the intention of the second rule to mark a test as failing. ========== to ========== [test] Fix joining FAIL expectations in status files Without this fix, two rules [PASS, MODIFIER] and [FAIL] would be joined as [PASS, MODIFIER, FAIL], undermining the intention of the second rule to mark a test as failing. BUG=v8:4900 ==========
Description was changed from ========== [test] Fix joining FAIL expectations in status files Without this fix, two rules [PASS, MODIFIER] and [FAIL] would be joined as [PASS, MODIFIER, FAIL], undermining the intention of the second rule to mark a test as failing. BUG=v8:4900 ========== to ========== [test] Fix joining FAIL expectations in status files Without this fix, two rules [PASS, MODIFIER] and [FAIL] would be joined as [PASS, MODIFIER, FAIL], undermining the intention of the second rule to mark a test as failing. BUG=v8:4680,v8:4900 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...) v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...) v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/10120) v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...) v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...) v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/10105) v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...) v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...) v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...) v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...) v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/10061) v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/6097) v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/20737)
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM on the status file changes. Note that I am not very proficient with the test-runner code, but it still looks reasonable to me FWIW.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [test] Fix joining FAIL expectations in status files Without this fix, two rules [PASS, MODIFIER] and [FAIL] would be joined as [PASS, MODIFIER, FAIL], undermining the intention of the second rule to mark a test as failing. BUG=v8:4680,v8:4900 ========== to ========== [test] Fix joining FAIL expectations in status files Without this fix, two rules [PASS, MODIFIER] and [FAIL] would be joined as [PASS, MODIFIER, FAIL], undermining the intention of the second rule to mark a test as failing. BUG=v8:4680,v8:4900 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [test] Fix joining FAIL expectations in status files Without this fix, two rules [PASS, MODIFIER] and [FAIL] would be joined as [PASS, MODIFIER, FAIL], undermining the intention of the second rule to mark a test as failing. BUG=v8:4680,v8:4900 ========== to ========== [test] Fix joining FAIL expectations in status files Without this fix, two rules [PASS, MODIFIER] and [FAIL] would be joined as [PASS, MODIFIER, FAIL], undermining the intention of the second rule to mark a test as failing. BUG=v8:4680,v8:4900 Committed: https://crrev.com/8552e6822317c48638eb25d71c902cffebee21f1 Cr-Commit-Position: refs/heads/master@{#38238} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/8552e6822317c48638eb25d71c902cffebee21f1 Cr-Commit-Position: refs/heads/master@{#38238} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
