Fix unit test failures with estimated durations and splice frames.

media/filters/source_buffer_stream.cc

Index: media/filters/source_buffer_stream.cc
diff --git a/media/filters/source_buffer_stream.cc b/media/filters/source_buffer_stream.cc
index 89281d65bb4288b29a7d748e88f5c35517d08a1e..58f58ced3042b8a4d88c22e3442d88243c5bd017 100644
--- a/media/filters/source_buffer_stream.cc
+++ b/media/filters/source_buffer_stream.cc
@@ -490,7 +490,8 @@ bool SourceBufferStream::Append(const BufferQueue& buffers) {
     last_appended_buffer_timestamp_ = buffers.back()->GetDecodeTimestamp();
     last_appended_buffer_is_keyframe_ = buffers.back()->IsKeyframe();
   } else {
-    base::TimeDelta new_range_start_time = media_segment_start_time_;
+    base::TimeDelta new_range_start_time =

[wolenetz, 2014/04/02 00:47:07]

If we allow range starts to be < media_segment_start_time_, does that mean that
we could be mishandling some edge cases instead of properly signaling
OnNewMediaSegment with the earlier start time?

[acolwell GONE FROM CHROMIUM, 2014/04/02 17:19:33]

I believe adding a DCHECK(media_segment_start_time_ <=
buffers.front()->timestamp()) at the top of this function would mitigate this
concern. If this fires it means that the caller is doing something wrong.

[DaleCurtis, 2014/04/02 21:53:43]

DCHECK() discussion moved to: https://codereview.chromium.org/222783007/

+        std::min(media_segment_start_time_, buffers.front()->timestamp());
     const BufferQueue* buffers_for_new_range = &buffers;
     BufferQueue trimmed_buffers;
 
@@ -1669,8 +1670,12 @@ SourceBufferRange::SourceBufferRange(
 
 void SourceBufferRange::AppendBuffersToEnd(const BufferQueue& new_buffers) {
   DCHECK(buffers_.empty() || CanAppendBuffersToEnd(new_buffers));
+  DCHECK(media_segment_start_time_ == kNoTimestamp() ||
+         media_segment_start_time_ <=
+             new_buffers.front()->GetDecodeTimestamp());
   for (BufferQueue::const_iterator itr = new_buffers.begin();
-       itr != new_buffers.end(); ++itr) {
+       itr != new_buffers.end();
+       ++itr) {
     DCHECK((*itr)->GetDecodeTimestamp() != kNoTimestamp());
     buffers_.push_back(*itr);
     size_in_bytes_ += (*itr)->data_size();