chromeos/disks/disk_mount_manager.cc - Issue 2201023002: Change access mode of disk devices when mounting based on config.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/disks/disk_mount_manager.cc

Issue 2201023002: Change access mode of disk devices when mounting based on config. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add test case to check read_only parameter to disk mount manager. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/file_manager/fake_disk_mount_manager.cc ('K') | « chromeos/disks/disk_mount_manager.h ('k') | chromeos/disks/mock_disk_mount_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/disks/disk_mount_manager.cc

diff --git a/chromeos/disks/disk_mount_manager.cc b/chromeos/disks/disk_mount_manager.cc

index 48ecf910f2bfd6f737e2c500e7299569f7471d31..f75e1ac44cda5428cb630ef2a3da1339b68a3dd6 100644

--- a/chromeos/disks/disk_mount_manager.cc

+++ b/chromeos/disks/disk_mount_manager.cc

@@ -68,7 +68,8 @@ class DiskMountManagerImpl : public DiskMountManager {

void MountPath(const std::string& source_path,

const std::string& source_format,

const std::string& mount_label,

- MountType type) override {

+ MountType type,

+ MountAccessMode access_mode) override {

// Hidden and non-existent devices should not be mounted.

if (type == MOUNT_TYPE_DEVICE) {

DiskMap::const_iterator it = disks_.find(source_path);

@@ -79,7 +80,7 @@ class DiskMountManagerImpl : public DiskMountManager {

}

cros_disks_client_->Mount(

- source_path, source_format, mount_label, MOUNT_ACCESS_MODE_READ_WRITE,

+ source_path, source_format, mount_label, access_mode,

// When succeeds, OnMountCompleted will be called by

// "MountCompleted" signal instead.

base::Bind(&base::DoNothing),