chrome/browser/chromeos/file_manager/volume_manager_unittest.cc - Issue 2201023002: Change access mode of disk devices when mounting based on config.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_manager/volume_manager_unittest.cc

Issue 2201023002: Change access mode of disk devices when mounting based on config. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Explicitly check if the preference has the path. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/file_manager/volume_manager.cc ('K') | « chrome/browser/chromeos/file_manager/volume_manager.cc ('k') | chrome/browser/chromeos/login/kiosk_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_manager/volume_manager_unittest.cc

diff --git a/chrome/browser/chromeos/file_manager/volume_manager_unittest.cc b/chrome/browser/chromeos/file_manager/volume_manager_unittest.cc

index fd325876b28ad945a9b91696ae5a98f5045ca615..c029bb3b83791869b186ad1d5aecb166e91859e5 100644

--- a/chrome/browser/chromeos/file_manager/volume_manager_unittest.cc

+++ b/chrome/browser/chromeos/file_manager/volume_manager_unittest.cc

@@ -524,8 +524,8 @@ TEST_F(VolumeManagerTest, OnMountEvent_Remounting) {

chromeos::DEVICE_TYPE_UNKNOWN, 0, false, false, false, false, false,

false));

disk_mount_manager_->AddDiskForTest(disk.release());

- disk_mount_manager_->MountPath(

- "device1", "", "", chromeos::MOUNT_TYPE_DEVICE);

+ disk_mount_manager_->MountPath("device1", "", "", chromeos::MOUNT_TYPE_DEVICE,

+ chromeos::MOUNT_ACCESS_MODE_READ_WRITE);

const chromeos::disks::DiskMountManager::MountPointInfo kMountPoint(

"device1",

@@ -674,10 +674,10 @@ TEST_F(VolumeManagerTest, OnFormatEvent_CompletedFailed) {

TEST_F(VolumeManagerTest, OnExternalStorageDisabledChanged) {

// Here create two mount points.

- disk_mount_manager_->MountPath(

- "mount1", "", "", chromeos::MOUNT_TYPE_DEVICE);

- disk_mount_manager_->MountPath(

- "mount2", "", "", chromeos::MOUNT_TYPE_DEVICE);

+ disk_mount_manager_->MountPath("mount1", "", "", chromeos::MOUNT_TYPE_DEVICE,

+ chromeos::MOUNT_ACCESS_MODE_READ_WRITE);

+ disk_mount_manager_->MountPath("mount2", "", "", chromeos::MOUNT_TYPE_DEVICE,

+ chromeos::MOUNT_ACCESS_MODE_READ_ONLY);

// Initially, there are two mount points.

ASSERT_EQ(2U, disk_mount_manager_->mount_points().size());