chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc - Issue 2201023002: Change access mode of disk devices when mounting based on config.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc

Issue 2201023002: Change access mode of disk devices when mounting based on config. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Explicitly check if the preference has the path. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/chromeos/file_manager/fake_disk_mount_manager.h » ('j') | chrome/browser/chromeos/file_manager/volume_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc

diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc b/chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc

index 2943bbff1f4aa3af1d072578fcf78287cdcfd73e..3da5dc94a809ca74969d0cd0b04749c1fb91f748 100644

--- a/chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc

+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc

@@ -163,8 +163,8 @@ void FileManagerPrivateAddMountFunction::RunAfterMarkCacheFileAsMounted(

disk_mount_manager->MountPath(

file_path.AsUTF8Unsafe(),

base::FilePath(display_name.Extension()).AsUTF8Unsafe(),

- display_name.AsUTF8Unsafe(),

- chromeos::MOUNT_TYPE_ARCHIVE);

+ display_name.AsUTF8Unsafe(), chromeos::MOUNT_TYPE_ARCHIVE,

+ chromeos::MOUNT_ACCESS_MODE_READ_WRITE);

}

bool FileManagerPrivateRemoveMountFunction::RunAsync() {

« no previous file with comments | « no previous file | chrome/browser/chromeos/file_manager/fake_disk_mount_manager.h » ('j') | chrome/browser/chromeos/file_manager/volume_manager.cc » ('J')