Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4284)

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc

Issue 2201023002: Change access mode of disk devices when mounting based on config. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc
diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc b/chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc
index 2943bbff1f4aa3af1d072578fcf78287cdcfd73e..9bb59027cd07e4690dd0d13ba13ba1e8a83c3714 100644
--- a/chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc
+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc
@@ -16,9 +16,11 @@
#include "chrome/browser/chromeos/file_manager/volume_manager.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/common/extensions/api/file_manager_private.h"
+#include "chrome/common/pref_names.h"
#include "chromeos/disks/disk_mount_manager.h"
#include "components/drive/chromeos/file_system_interface.h"
#include "components/drive/event_logger.h"
+#include "components/prefs/pref_service.h"
#include "content/public/browser/browser_thread.h"
#include "google_apis/drive/task_util.h"
#include "ui/shell_dialogs/selected_file_info.h"
@@ -160,11 +162,15 @@ void FileManagerPrivateAddMountFunction::RunAfterMarkCacheFileAsMounted(
// MountPath() takes a std::string.
DiskMountManager* disk_mount_manager = DiskMountManager::GetInstance();
+ bool read_only =
+ GetProfile()->GetPrefs()->GetBoolean(prefs::kExternalStorageReadOnly);
+ chromeos::MountAccessMode access_mode =
+ read_only ? chromeos::MOUNT_ACCESS_MODE_READ_ONLY
+ : chromeos::MOUNT_ACCESS_MODE_READ_WRITE;
disk_mount_manager->MountPath(
file_path.AsUTF8Unsafe(),
base::FilePath(display_name.Extension()).AsUTF8Unsafe(),
- display_name.AsUTF8Unsafe(),
- chromeos::MOUNT_TYPE_ARCHIVE);
+ display_name.AsUTF8Unsafe(), chromeos::MOUNT_TYPE_ARCHIVE, access_mode);
fukino 2016/08/03 07:18:19 Should we specify access mode for mounted archive
yamaguchi 2016/08/03 10:22:14 Done. Mounted archives are treated as read-only by
}
bool FileManagerPrivateRemoveMountFunction::RunAsync() {

Powered by Google App Engine
This is Rietveld 408576698