components/sessions/core/persistent_tab_restore_service.h - Issue 2200993004: Make TabRestoreService::Entry noncopyable and fix up surrounding code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sessions/core/persistent_tab_restore_service.h

Issue 2200993004: Make TabRestoreService::Entry noncopyable and fix up surrounding code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tab-test-cleanup

Patch Set: Add back NOTREACHED() and a return for gcc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/history_menu_bridge_unittest.mm ('K') | « components/sessions/content/content_platform_specific_tab_data.cc ('k') | components/sessions/core/persistent_tab_restore_service.cc » ('j') | components/sessions/core/tab_restore_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sessions/core/persistent_tab_restore_service.h

diff --git a/components/sessions/core/persistent_tab_restore_service.h b/components/sessions/core/persistent_tab_restore_service.h

index ac3ffd4125b2bd86291b083b6fe22f93db741c90..fabe9245fc24dec1a8326418c4c0db518ca35255 100644

--- a/components/sessions/core/persistent_tab_restore_service.h

+++ b/components/sessions/core/persistent_tab_restore_service.h

@@ -31,14 +31,14 @@ class SESSIONS_EXPORT PersistentTabRestoreService : public TabRestoreService {

// TabRestoreService:

void AddObserver(TabRestoreServiceObserver* observer) override;

void RemoveObserver(TabRestoreServiceObserver* observer) override;

- void CreateHistoricalTab(LiveTab* live_tab, int index) override;

+ void CreateHistoricalTab(LiveTab* live_tab, size_t index) override;

void BrowserClosing(LiveTabContext* context) override;

void BrowserClosed(LiveTabContext* context) override;

void ClearEntries() override;

const Entries& entries() const override;

std::vector<LiveTab*> RestoreMostRecentEntry(

LiveTabContext* context) override;

- Tab* RemoveTabEntryById(SessionID::id_type id) override;

+ std::unique_ptr<Tab> RemoveTabEntryById(SessionID::id_type id) override;

std::vector<LiveTab*> RestoreEntryById(

LiveTabContext* context,

SessionID::id_type id,