chrome/browser/ui/browser_commands.cc - Issue 2200993004: Make TabRestoreService::Entry noncopyable and fix up surrounding code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_commands.cc

Issue 2200993004: Make TabRestoreService::Entry noncopyable and fix up surrounding code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tab-test-cleanup

Patch Set: Add back NOTREACHED() and a return for gcc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/sessions/sessions_api.cc ('K') | « chrome/browser/sessions/persistent_tab_restore_service_unittest.cc ('k') | chrome/browser/ui/cocoa/history_menu_bridge.mm » ('j') | chrome/browser/ui/cocoa/history_menu_bridge.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_commands.cc

diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc

index 8a77489e6fc1be74f317155d4657a0a112fb6b48..27d3132feba18c14fe921fa11072fc217b413fe1 100644

--- a/chrome/browser/ui/browser_commands.cc

+++ b/chrome/browser/ui/browser_commands.cc

@@ -603,7 +603,7 @@ TabStripModelDelegate::RestoreTabType GetRestoreTabType(

TabRestoreServiceFactory::GetForProfile(browser->profile());

if (!service || service->entries().empty())

return TabStripModelDelegate::RESTORE_NONE;

- if (service->entries().front()->type == sessions::TabRestoreService::WINDOW)

+ if (service->entries().front()->type() == sessions::TabRestoreService::WINDOW)

return TabStripModelDelegate::RESTORE_WINDOW;

return TabStripModelDelegate::RESTORE_TAB;

}